Skip to content

Conversation

@miss-islington
Copy link
Contributor

@miss-islington miss-islington commented Nov 12, 2025

  • Increase test coverage for csv.DictReader and csv.Sniffer

Previously there were no tests for the DictReader fieldnames
setter, the case where a StopIteration was encountered when trying
to determine the fieldnames from the content or the case where
Sniffer could not find a delimiter.

  • Revert whitespace change to comment

  • Add a test that csv.Sniffer.has_header checks up to 20 rows

  • Replace name and age with letter and offset

Co-authored-by: Bénédikt Tran 10796600+picnixz@users.noreply.github.com

  • Address review comment

(cherry picked from commit 0e88be6)

Co-authored-by: Jan-Eric Nitschke 47750513+JanEricNitschke@users.noreply.github.com
Co-authored-by: Bénédikt Tran 10796600+picnixz@users.noreply.github.com
Co-authored-by: Gregory P. Smith 68491+gpshead@users.noreply.github.com

…iffer (pythonGH-138622)

* Increase test coverage for csv.DictReader and csv.Sniffer

Previously there were no tests for the DictReader fieldnames
setter, the case where a StopIteration was encountered when trying
to determine the fieldnames from the content or the case where
Sniffer could not find a delimiter.

* Revert whitespace change to comment

* Add a test that csv.Sniffer.has_header checks up to 20 rows

* Replace name and age with letter and offset

Co-authored-by: Bénédikt Tran <10796600+picnixz@users.noreply.github.com>

* Address review comment

---------
(cherry picked from commit 0e88be6)

Co-authored-by: Jan-Eric Nitschke <47750513+JanEricNitschke@users.noreply.github.com>
Co-authored-by: Bénédikt Tran <10796600+picnixz@users.noreply.github.com>
Co-authored-by: Gregory P. Smith <68491+gpshead@users.noreply.github.com>
@bedevere-app bedevere-app bot added skip news awaiting review tests Tests in the Lib/test dir labels Nov 12, 2025
@gpshead gpshead enabled auto-merge (squash) November 12, 2025 00:36
@gpshead gpshead merged commit 947354e into python:3.14 Nov 12, 2025
51 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

skip news tests Tests in the Lib/test dir

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants