Skip to content

[3.13] gh-141442: Add escaping to iOS testbed arguments (GH-141443) #141480

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Nov 12, 2025
+3 −1
Merged

[3.13] gh-141442: Add escaping to iOS testbed arguments (GH-141443) #141480

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
1 change: 1 addition & 0 deletions Misc/NEWS.d/next/Tools-Demos/2025-11-12-12-54-28.gh-issue-141442.50dS3P.rst
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -0,0 +1 @@
The iOS testbed now correctly handles test arguments that contain spaces.
3 changes: 2 additions & 1 deletion iOS/testbed/__main__.py
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,6 +1,7 @@
import argparse
import json
import re
import shlex
import shutil
import subprocess
import sys
Expand Down Expand Up @@ -206,7 +207,7 @@ def update_test_plan(testbed_path, args):
test_plan = json.load(f)

test_plan["defaultOptions"]["commandLineArgumentEntries"] = [
{"argument": arg} for arg in args
{"argument": shlex.quote(arg)} for arg in args
]

with test_plan_path.open("w", encoding="utf-8") as f:
Expand Down
Loading