Skip to content

Conversation

@encukou
Copy link
Member

@encukou encukou commented Nov 17, 2025

…ket can't connect (pythonGH-140835)

Co-authored-by: codenamenam <bluetire27@gmail.com>
(cherry picked from commit f2bce51)
@encukou encukou changed the title gh-140691: urllib.request: Close FTP control socket if data socket can't connect (GH-140835) [3.13] gh-140691: urllib.request: Close FTP control socket if data socket can't connect (GH-140835) Nov 17, 2025
@efimov-mikhail
Copy link
Member

efimov-mikhail commented Nov 17, 2025

This backport looks correct for me.
But why we don't provide a change to class WarningMessage?
I understand that Lib/_py_warnings.py could not be patched on 3.13, but we could patch Lib/warnings.py.

@encukou
Copy link
Member Author

encukou commented Nov 17, 2025

That's not a bugfix, so when the conflict came up I removed the change.
The repr was rather useful for diagnostics, but I don't think it's that important in backports.

@encukou encukou added the 🔨 test-with-buildbots Test PR w/ buildbots; report in status section label Nov 17, 2025
@bedevere-bot
Copy link

🤖 New build scheduled with the buildbot fleet by @encukou for commit dd39581 🤖

Results will be shown at:

https://buildbot.python.org/all/#/grid?branch=refs%2Fpull%2F141657%2Fmerge

If you want to schedule another build, you need to add the 🔨 test-with-buildbots label again.

@bedevere-bot bedevere-bot removed the 🔨 test-with-buildbots Test PR w/ buildbots; report in status section label Nov 17, 2025
@encukou encukou merged commit 1bca1b4 into python:3.13 Nov 18, 2025
108 of 112 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants