gh-140042: Removing unsafe call to sqlite3_shutdown

[prithviraj-chaudhuri]

This commit addresses this issue #140042 (comment).
It removes the sqlite3_shutdown call that could cause closing connections for sqlite when used with multiple sub interpreters.

• Issue: _sqlite3 C module: sqlite3_shutdown is not safe to call with sub-interpreters #140042

[python-cla-bot]

All commit authors signed the Contributor License Agreement.

[bedevere-app]

Most changes to Python require a NEWS entry. Add one using the blurb_it web app or the blurb command-line tool.

If this change has little impact on Python users, wait for a maintainer to apply the skip news label instead.

[encukou]

Thank you.

I don't see a good way to add a test here -- we'd need to inject a failure in the module initialization logic, and then watch undefined behaviour.

If we want to clean up properly, we should call sqlite3_shutdown in e.g. module_free. That's not the case here -- sqlite3 leaks in the “happy” path. Also leaking on error isn't a big issue.

(Presumably we leak a fixed amount of resources per process, so adding proper calls to sqlite3_shutdown isn't a big priority.)

@erlend-aasland, do you want to take a look?
I'll merge around Thursday if there are no objections.

[miss-islington-app]

Thanks @prithviraj-chaudhuri for the PR, and @encukou for merging it 🌮🎉.. I'm working now to backport this PR to: 3.13, 3.14.
🐍🍒⛏🤖

[bedevere-app]

GH-141793 is a backport of this pull request to the 3.14 branch.

[miss-islington-app]

Sorry, @prithviraj-chaudhuri and @encukou, I could not cleanly backport this to 3.13 due to a conflict.
Please backport using cherry_picker on command line.

cherry_picker b1558b6d3e2af8964840a5c00356533107368f22 3.13