Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

bpo-37305: add MIME type for Web App Manifest #14199

Merged
merged 4 commits into from Sep 11, 2019

Conversation

@filips123
Copy link
Contributor

commented Jun 18, 2019

Add .webmanifest -> application/manifest+json to list of recognized file types and content type headers.

Note that application/manifest+json is currently not registered with IANA (but it will be soon), so I can move it to common_types if needed.

Issue: https://bugs.python.org/issue37305

https://bugs.python.org/issue37305

@filips123 filips123 requested a review from python/email-team as a code owner Jun 18, 2019

@the-knights-who-say-ni

This comment has been minimized.

Copy link

commented Jun 18, 2019

Hello, and thanks for your contribution!

I'm a bot set up to make sure that the project can legally accept your contribution by verifying you have signed the PSF contributor agreement (CLA).

Our records indicate we have not received your CLA. For legal reasons we need you to sign this before we can look at your contribution. Please follow the steps outlined in the CPython devguide to rectify this issue.

If you have recently signed the CLA, please wait at least one business day
before our records are updated.

You can check yourself to see if the CLA has been received.

Thanks again for your contribution, we look forward to reviewing it!

@filips123

This comment has been minimized.

Copy link
Contributor Author

commented Jun 18, 2019

I signed the CLA today so it is currently not updated.

@filips123

This comment has been minimized.

Copy link
Contributor Author

commented Jun 19, 2019

Ok, it is now confirmed to be signed.

@tirkarthi

This comment has been minimized.

Copy link
Contributor

commented Jun 19, 2019

I think you have also reformatted the dictionary and the indentation change makes the diff larger than the one line change done.

@filips123

This comment has been minimized.

Copy link
Contributor Author

commented Jun 19, 2019

@tirkarthi I indented all lines because .webmanifest key was too long.

@jaraco
jaraco approved these changes Sep 11, 2019
Copy link
Member

left a comment

This change looks right to me.

@jaraco

This comment has been minimized.

Copy link
Member

commented Sep 11, 2019

I notice that previously the mapping was ordered by value alphabetically. We should retain that form.

@jaraco jaraco self-assigned this Sep 11, 2019

@jaraco jaraco merged commit 4b41745 into python:master Sep 11, 2019

4 of 5 checks passed

continuous-integration/appveyor/pr Waiting for AppVeyor build to complete
Details
Azure Pipelines PR #20190911.105 succeeded
Details
bedevere/issue-number Issue number 37305 found
Details
bedevere/news News entry found in Misc/NEWS.d
continuous-integration/travis-ci/pr The Travis CI build passed
Details
@bedevere-bot

This comment has been minimized.

Copy link

commented Sep 11, 2019

@jaraco: Please replace # with GH- in the commit message next time. Thanks!

@miss-islington

This comment has been minimized.

Copy link

commented Sep 11, 2019

Thanks @filips123 for the PR, and @jaraco for merging it 🌮🎉.. I'm working now to backport this PR to: 3.8.
🐍🍒🤖

miss-islington added a commit to miss-islington/cpython that referenced this pull request Sep 11, 2019
bpo-37305: add MIME type for Web App Manifest (pythonGH-14199)
* bpo-37305: add MIME type for Web App Manifest

* bpo-37305: add news entry

* Restore indentation and sort by value
(cherry picked from commit 4b41745)

Co-authored-by: Filip Š <filip.stamcar@hotmail.com>
@bedevere-bot

This comment has been minimized.

Copy link

commented Sep 11, 2019

GH-15946 is a backport of this pull request to the 3.8 branch.

jaraco added a commit that referenced this pull request Sep 11, 2019
bpo-37305: add MIME type for Web App Manifest (GH-14199) (#15946)
* bpo-37305: add MIME type for Web App Manifest

Co-authored-by: Filip Š <filip.stamcar@hotmail.com>
vrpolakatcisco added a commit to vrpolakatcisco/cpython that referenced this pull request Sep 12, 2019
bpo-37305: add MIME type for Web App Manifest (python#14199)
* bpo-37305: add MIME type for Web App Manifest

* bpo-37305: add news entry

* Restore indentation and sort by value
DinoV added a commit to DinoV/cpython that referenced this pull request Sep 12, 2019
bpo-37305: add MIME type for Web App Manifest (python#14199)
* bpo-37305: add MIME type for Web App Manifest

* bpo-37305: add news entry

* Restore indentation and sort by value
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
6 participants
You can’t perform that action at this time.