Skip to content

gh-141968: Use take_bytes in re._compiler #141995

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 3 commits into from
Nov 28, 2025
+3 −1
Merged

gh-141968: Use take_bytes in re._compiler #141995

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
3 commits
Select commit Hold shift + click to select a range
c2a0b52
gh-141968: Use take_byes in re._compiler
cmaloney Nov 26, 2025
4c2924f
Fix typo in blurb
cmaloney Nov 26, 2025
9fb0725
Update Misc/NEWS.d/next/Library/2025-11-26-14-20-10.gh-issue-141968.W…
vstinner Nov 28, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion Lib/re/_compiler.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -375,7 +375,7 @@ def _optimize_charset(charset, iscased=None, fixup=None, fixes=None):
# less significant byte is a bit index in the chunk (just like the
# CHARSET matching).

charmap = bytes(charmap) # should be hashable
charmap = charmap.take_bytes() # should be hashable
comps = {}
mapping = bytearray(256)
block = 0
Expand Down
2 changes: 2 additions & 0 deletions Misc/NEWS.d/next/Library/2025-11-26-14-20-10.gh-issue-141968.W139Pv.rst
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -0,0 +1,2 @@
Remove data copy from :mod:`re` compilation of regexes with large charsets
by using :meth:`bytearray.take_bytes`.
Loading