gh-141938: Fix HTTPConnection being stuck in a dirty state when HTTPResponse.begin() raises exceptions/errors #142047
Conversation
… response.begin() raises exceptions When response.begin() raises an exception other than ConnectionError (such as TimeoutError), the outer exception handler calls response.close() but not self.close(), leaving the HTTPConnection's internal state stuck at _CS_REQ_SENT instead of being reset to _CS_IDLE. This causes subsequent requests on the same connection to raise CannotSendRequest even though the underlying socket has been closed. The fix changes the outer exception handler to call self.close() instead of just response.close(). This properly resets the connection state and closes the socket, consistent with the inner ConnectionError handler.
TotalyEnglizLitrate
changed the title
TotalyEnglizLitrate
changed the title
|
All commit authors signed the Contributor License Agreement. |
|
I will close this PR until (1) tests pass (2) we decide to change this behavior. As you can see this change broke the test suite. |
|
I seem to have ran the tests on the main branch locally and thought it passed 😅 The erroneous behavior stemmed from the fact that If the decision is made to change this behavior the test would also need to be modified as closing the connection will set |
2 participants
When
HTTPConnection.getresponse()encounters an exception/error (likeTimeoutError) while reading the response, the outer exception handler callsresponse.close()but notself.close(). This closes the socket but leaves the connection's internal state stuck at_CS_REQ_SENT, causing subsequent requests on the same connection object to raiseCannotSendRequest.This change correctly closes the connection instead of the response.