Skip to content

Conversation

@AA-Turner
Copy link
Member

@AA-Turner AA-Turner commented Nov 29, 2025

cc @hugovk @picnixz

Resolves the following:

...\Doc\howto\urllib2.rst:479: ERROR: Duplicate target name, cannot be used as a unique reference: "basic authentication". [docutils]
...\Doc\library\socket.rst:2099: WARNING: more than one target found for cross-reference 'buffer': io.TextIOBase.buffer, unittest.TestResult.buffer [ref.python]

A


📚 Documentation preview 📚: https://cpython-previews--142057.org.readthedocs.build/

@AA-Turner AA-Turner requested a review from hugovk as a code owner November 29, 2025 00:54
@AA-Turner AA-Turner added docs Documentation in the Doc dir skip news needs backport to 3.13 bugs and security fixes needs backport to 3.14 bugs and security fixes labels Nov 29, 2025
@github-project-automation github-project-automation bot moved this to Todo in Docs PRs Nov 29, 2025
terms[term.lower()] = {
'title': term,
'body': rendered['html_body'],
'body': rendered['fragment'],
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

What does this do?

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

body and fragment are aliases. html_body wraps the fragment content in <main> tags, but that's not needed/helpful for this use-case (inserting into the search results).

A

with Python:

* `Basic Authentication <https://web.archive.org/web/20201215133350/http://www.voidspace.org.uk/python/articles/authentication.shtml>`_
* `Basic Authentication <https://web.archive.org/web/20201215133350/http://www.voidspace.org.uk/python/articles/authentication.shtml>`__
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I guess we should generally use anonymous targets as a default, unless we specifically want a named one?

Needing a named one is probably rare.

If so, we could update the examples in the devguide, perhaps with a brief explanation.

And suggest anonymous in reviews.

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@hugovk hugovk merged commit 7739943 into python:main Nov 29, 2025
45 checks passed
@github-project-automation github-project-automation bot moved this from Todo to Done in Docs PRs Nov 29, 2025
@miss-islington-app
Copy link

Thanks @AA-Turner for the PR, and @hugovk for merging it 🌮🎉.. I'm working now to backport this PR to: 3.13, 3.14.
🐍🍒⛏🤖

miss-islington pushed a commit to miss-islington/cpython that referenced this pull request Nov 29, 2025
(cherry picked from commit 7739943)

Co-authored-by: Adam Turner <9087854+AA-Turner@users.noreply.github.com>
@bedevere-app
Copy link

bedevere-app bot commented Nov 29, 2025

GH-142091 is a backport of this pull request to the 3.14 branch.

miss-islington pushed a commit to miss-islington/cpython that referenced this pull request Nov 29, 2025
(cherry picked from commit 7739943)

Co-authored-by: Adam Turner <9087854+AA-Turner@users.noreply.github.com>
@bedevere-app bedevere-app bot removed the needs backport to 3.14 bugs and security fixes label Nov 29, 2025
@bedevere-app
Copy link

bedevere-app bot commented Nov 29, 2025

GH-142092 is a backport of this pull request to the 3.13 branch.

@bedevere-app bedevere-app bot removed the needs backport to 3.13 bugs and security fixes label Nov 29, 2025
@AA-Turner AA-Turner deleted the docs/sphinx-9-prep branch November 29, 2025 14:50
hugovk pushed a commit that referenced this pull request Nov 29, 2025
Co-authored-by: Adam Turner <9087854+AA-Turner@users.noreply.github.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

docs Documentation in the Doc dir skip issue skip news

Projects

Status: Done

Development

Successfully merging this pull request may close these issues.

3 participants