-
-
Notifications
You must be signed in to change notification settings - Fork 33.6k
gh-141473: Document not calling Popen.wait after Popen.communicate times out. #142101
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Merged
gpshead
merged 1 commit into
python:main
from
gpshead:gh141473/subprocess-doc-no-wait-after-communicate
Dec 1, 2025
Merged
gh-141473: Document not calling Popen.wait after Popen.communicate times out. #142101
gpshead
merged 1 commit into
python:main
from
gpshead:gh141473/subprocess-doc-no-wait-after-communicate
Dec 1, 2025
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Thanks @gpshead for the PR 🌮🎉.. I'm working now to backport this PR to: 3.13, 3.14. |
miss-islington
pushed a commit
to miss-islington/cpython
that referenced
this pull request
Dec 1, 2025
…ate times out. (pythonGH-142101) Document not calling Popen.wait after Popen.communicate times out. Closes pythonGH-141473 (cherry picked from commit 3e2c557) Co-authored-by: Gregory P. Smith <68491+gpshead@users.noreply.github.com>
|
GH-142124 is a backport of this pull request to the 3.14 branch. |
miss-islington
pushed a commit
to miss-islington/cpython
that referenced
this pull request
Dec 1, 2025
…ate times out. (pythonGH-142101) Document not calling Popen.wait after Popen.communicate times out. Closes pythonGH-141473 (cherry picked from commit 3e2c557) Co-authored-by: Gregory P. Smith <68491+gpshead@users.noreply.github.com>
|
GH-142125 is a backport of this pull request to the 3.13 branch. |
gpshead
added a commit
that referenced
this pull request
Dec 1, 2025
…cate times out. (GH-142101) (#142124) gh-141473: Document not calling Popen.wait after Popen.communicate times out. (GH-142101) Document not calling Popen.wait after Popen.communicate times out. Closes GH-141473 (cherry picked from commit 3e2c557) Co-authored-by: Gregory P. Smith <68491+gpshead@users.noreply.github.com>
gpshead
added a commit
that referenced
this pull request
Dec 1, 2025
…cate times out. (GH-142101) (#142125) gh-141473: Document not calling Popen.wait after Popen.communicate times out. (GH-142101) Document not calling Popen.wait after Popen.communicate times out. Closes GH-141473 (cherry picked from commit 3e2c557) Co-authored-by: Gregory P. Smith <68491+gpshead@users.noreply.github.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Labels
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
📚 Documentation preview 📚: https://cpython-previews--142101.org.readthedocs.build/