Skip to content

Docs: fix RFC index reference for TLS 1.3 #142262

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
picnixz merged 2 commits into from
Dec 6, 2025
Merged

Docs: fix RFC index reference for TLS 1.3 #142262

picnixz merged 2 commits into from
Dec 6, 2025

Conversation

@Geno1024
Copy link
Contributor

@Geno1024 Geno1024 commented Dec 4, 2025

A small typo in Lib/ssl.py.

TLS v1.3 is RFC 8446, not RFC 8466.

@bedevere-app
Copy link

bedevere-app bot commented Dec 4, 2025

Most changes to Python require a NEWS entry. Add one using the blurb_it web app or the blurb command-line tool.

If this change has little impact on Python users, wait for a maintainer to apply the skip news label instead.

@Geno1024
Copy link
Contributor Author

Geno1024 commented Dec 6, 2025

@ZeroIntensity Do I need to do something, like make a PR to branch 3.13 and 3.14, as the response of PR tag "needs backport to 3.13" and "needs backport to 3.14"?

@aisk
Copy link
Contributor

aisk commented Dec 6, 2025

@Geno1024 No, you needn't do anything. These tags are used for a Github bot which will backport a PR to the specified version branch once been merged. See: https://devguide.python.org/triage/labels/#labels-specific-to-prs

picnixz
picnixz reviewed Dec 6, 2025
View reviewed changes
Copy link
Member

@picnixz picnixz left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Can you check if the online docs also have this issue please?

@picnixz picnixz changed the title Fix typo: comment in ssl.py Docs: fix RFC index reference for TLS 1.3 Dec 6, 2025
@Geno1024
Copy link
Contributor Author

Geno1024 commented Dec 6, 2025

Can you check if the online docs also have this issue please?

@picnixz I have verified that,

  1. grep -r 8466 doesn't show any other same typo.
  2. All 26 occurrences of word "RFC" in Doc/library/ssl.rst, 7 occurrences of word "RFC" in Lib/ssl.py, 11 occurrences of word "RFC" in Lib/test/test_ssl.py points to correct RFC index.

@picnixz picnixz merged commit 61823a5 into python:main Dec 6, 2025
44 checks passed
@miss-islington-app
Copy link

miss-islington-app bot commented Dec 6, 2025

Thanks @Geno1024 for the PR, and @picnixz for merging it 🌮🎉.. I'm working now to backport this PR to: 3.13, 3.14.
🐍🍒⛏🤖

@picnixz
Copy link
Member

picnixz commented Dec 6, 2025

Thank you!

miss-islington pushed a commit to miss-islington/cpython that referenced this pull request Dec 6, 2025
@Geno1024 @miss-islington
Docs: fix RFC index reference for TLS 1.3 (pythonGH-142262)
d5791ad 
(cherry picked from commit 61823a5)

Co-authored-by: Y. Z. Chen <754097987@qq.com>
miss-islington pushed a commit to miss-islington/cpython that referenced this pull request Dec 6, 2025
@Geno1024 @miss-islington
Docs: fix RFC index reference for TLS 1.3 (pythonGH-142262)
d68138a 
(cherry picked from commit 61823a5)

Co-authored-by: Y. Z. Chen <754097987@qq.com>
@bedevere-app
Copy link

bedevere-app bot commented Dec 6, 2025

GH-142340 is a backport of this pull request to the 3.14 branch.

@bedevere-app bedevere-app bot removed the needs backport to 3.14 bugs and security fixes label Dec 6, 2025
@bedevere-app
Copy link

bedevere-app bot commented Dec 6, 2025

GH-142341 is a backport of this pull request to the 3.13 branch.

@bedevere-app bedevere-app bot removed the needs backport to 3.13 bugs and security fixes label Dec 6, 2025
picnixz pushed a commit that referenced this pull request Dec 6, 2025
@miss-islington @Geno1024
[3.13] Docs: fix RFC index reference for TLS 1.3 (GH-142262) (#142341)
462541c 
Docs: fix RFC index reference for TLS 1.3 (GH-142262)
(cherry picked from commit 61823a5)

Co-authored-by: Y. Z. Chen <754097987@qq.com>
picnixz pushed a commit that referenced this pull request Dec 6, 2025
@miss-islington @Geno1024
[3.14] Docs: fix RFC index reference for TLS 1.3 (GH-142262) (#142340)
95d19fc 
Docs: fix RFC index reference for TLS 1.3 (GH-142262)
(cherry picked from commit 61823a5)

Co-authored-by: Y. Z. Chen <754097987@qq.com>
StanFromIreland pushed a commit to StanFromIreland/cpython that referenced this pull request Dec 6, 2025
@Geno1024 @StanFromIreland
Docs: fix RFC index reference for TLS 1.3 (python#142262)
1cf12f1
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@aisk aisk aisk approved these changes

@picnixz picnixz picnixz approved these changes

@ZeroIntensity ZeroIntensity ZeroIntensity approved these changes

@gpshead gpshead Awaiting requested review from gpshead gpshead is a code owner

Assignees

No one assigned

Labels

skip issue skip news

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

4 participants

@Geno1024 @aisk @picnixz @ZeroIntensity