Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

bpo-35224: Add What's new entry for evaluation order in dict comprehensions #14319

Merged
merged 2 commits into from Jun 25, 2019

Conversation

@pablogsal
Copy link
Member

commented Jun 23, 2019

pablogsal added 2 commits Jun 23, 2019

@pablogsal pablogsal merged commit b51b713 into python:master Jun 25, 2019

5 checks passed

Azure Pipelines PR #20190625.7 succeeded
Details
bedevere/issue-number Issue number 35224 found
Details
bedevere/news "skip news" label found
continuous-integration/appveyor/pr AppVeyor build succeeded
Details
continuous-integration/travis-ci/pr The Travis CI build passed
Details
@miss-islington

This comment has been minimized.

Copy link

commented Jun 25, 2019

Thanks @pablogsal for the PR 🌮🎉.. I'm working now to backport this PR to: 3.8.
🐍🍒🤖

@pablogsal pablogsal deleted the pablogsal:bpo35224-2 branch Jun 25, 2019

miss-islington added a commit to miss-islington/cpython that referenced this pull request Jun 25, 2019
bpo-35224: Add What's new entry for evaluation order in dict comprehe…
…nsions (pythonGH-14319)

(cherry picked from commit b51b713)

Co-authored-by: Pablo Galindo <Pablogsal@gmail.com>
@bedevere-bot

This comment has been minimized.

Copy link

commented Jun 25, 2019

GH-14361 is a backport of this pull request to the 3.8 branch.

miss-islington added a commit that referenced this pull request Jun 25, 2019
bpo-35224: Add What's new entry for evaluation order in dict comprehe…
…nsions (GH-14319)

(cherry picked from commit b51b713)

Co-authored-by: Pablo Galindo <Pablogsal@gmail.com>
* The :opcode:`MAP_ADD` now expects the value as the first element in the
stack and the key as the second element. This change was made so the key
is always evaluated before the value in dictionary comprehensions, as
porposed by :pep:`572`. (Contributed by Jörn Heissler in :issue:`35224`.)

This comment has been minimized.

Copy link
@gvanrossum

gvanrossum Jun 25, 2019

Member

porposed -> proposed

This comment has been minimized.

Copy link
@pablogsal

pablogsal Jun 25, 2019

Author Member

Fixed in #14371

LorenzMende added a commit to LorenzMende/cpython that referenced this pull request Aug 11, 2019
PatrikKopkan pushed a commit to PatrikKopkan/cpython that referenced this pull request Sep 6, 2019
lisroach added a commit to lisroach/cpython that referenced this pull request Sep 10, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
6 participants
You can’t perform that action at this time.