Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[3.8] bpo-37412: os.getcwdb() now uses UTF-8 on Windows (GH-14396) #14399

Merged
merged 1 commit into from Jun 26, 2019

Conversation

@miss-islington
Copy link

miss-islington commented Jun 26, 2019

The os.getcwdb() function now uses the UTF-8 encoding on Windows,
rather than the ANSI code page: see PEP 529 for the rationale. The
function is no longer deprecated on Windows.

os.getcwd() and os.getcwdb() now detect integer overflow on memory
allocations. On Unix, these functions properly report MemoryError on
memory allocation failure.
(cherry picked from commit 689830e)

Co-authored-by: Victor Stinner vstinner@redhat.com

https://bugs.python.org/issue37412

The os.getcwdb() function now uses the UTF-8 encoding on Windows,
rather than the ANSI code page: see PEP 529 for the rationale. The
function is no longer deprecated on Windows.

os.getcwd() and os.getcwdb() now detect integer overflow on memory
allocations. On Unix, these functions properly report MemoryError on
memory allocation failure.
(cherry picked from commit 689830e)

Co-authored-by: Victor Stinner <vstinner@redhat.com>
Copy link
Member

vstinner left a comment

LGTM, good bot.

@miss-islington

This comment has been minimized.

Copy link
Author

miss-islington commented Jun 26, 2019

@vstinner: Status check is done, and it's a success .

@miss-islington miss-islington merged commit 63429c8 into python:3.8 Jun 26, 2019
6 checks passed
6 checks passed
Azure Pipelines PR #20190626.35 succeeded
Details
bedevere/issue-number Issue number 37412 found
Details
bedevere/maintenance-branch-pr Valid maintenance branch PR title.
bedevere/news News entry found in Misc/NEWS.d
continuous-integration/appveyor/pr AppVeyor build succeeded
Details
continuous-integration/travis-ci/pr The Travis CI build passed
Details
@miss-islington miss-islington deleted the miss-islington:backport-689830e-3.8 branch Jun 26, 2019
@miss-islington

This comment has been minimized.

Copy link
Author

miss-islington commented Jun 26, 2019

@vstinner: Status check is done, and it's a success .

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
4 participants
You can’t perform that action at this time.