Skip to content

bpo-30225: Fix is_valid_fd() on macOS Tiger #1443

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
May 3, 2017
Merged

bpo-30225: Fix is_valid_fd() on macOS Tiger #1443

merged 1 commit into from
May 3, 2017

Conversation

@vstinner
Copy link
Member

@vstinner vstinner commented May 3, 2017

is_valid_fd() now uses fstat() instead of dup() on macOS to return 0
on a pipe when the other side of the pipe is closed. fstat() fails
with EBADF in that case, whereas dup() succeed.

@vstinner
bpo-30225: Fix is_valid_fd() on macOS Tiger
3573a0a 
is_valid_fd() now uses fstat() instead of dup() on macOS to return 0
on a pipe when the other side of the pipe is closed. fstat() fails
with EBADF in that case, whereas dup() succeed.
@mention-bot
Copy link

mention-bot commented May 3, 2017

@Haypo, thanks for your PR! By analyzing the history of the files in this pull request, we identified @ncoghlan, @vadmium and @zooba to be potential reviewers.

@vstinner
Copy link
Member Author

vstinner commented May 3, 2017

I tested manually that this change fixes http://bugs.python.org/issue30225 on macOS Tiger. (I got a SSH access to the buildbot slave.)

@vstinner vstinner merged commit 1c4670e into python:master May 3, 2017
@vstinner vstinner deleted the is_valid_fd_tiger branch May 3, 2017 22:46
vstinner added a commit that referenced this pull request May 4, 2017
@vstinner
bpo-30225: Fix is_valid_fd() on macOS Tiger (#1443) (#1449)
31906b4 
is_valid_fd() now uses fstat() instead of dup() on macOS to return 0
on a pipe when the other side of the pipe is closed. fstat() fails
with EBADF in that case, whereas dup() succeed.
(cherry picked from commit 1c4670e)
vstinner added a commit that referenced this pull request May 4, 2017
@vstinner
bpo-30225: Fix is_valid_fd() on macOS Tiger (#1443) (#1450)
8a1c710 
is_valid_fd() now uses fstat() instead of dup() on macOS to return 0
on a pipe when the other side of the pipe is closed. fstat() fails
with EBADF in that case, whereas dup() succeed.
(cherry picked from commit 1c4670e)
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

No reviews

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

3 participants

@vstinner @mention-bot @the-knights-who-say-ni