From ca63b3d77f48f4b3d96e80fad5bc4dd0c0bf5647 Mon Sep 17 00:00:00 2001 From: sgal <32255369+sgalal@users.noreply.github.com> Date: Mon, 15 Jul 2019 13:43:02 -0700 Subject: [PATCH 1/4] Remove a vague statement in documentation --- Doc/c-api/long.rst | 3 +-- 1 file changed, 1 insertion(+), 2 deletions(-) diff --git a/Doc/c-api/long.rst b/Doc/c-api/long.rst index fdaefafe21ba09..19b04fc7b0b0cb 100644 --- a/Doc/c-api/long.rst +++ b/Doc/c-api/long.rst @@ -43,8 +43,7 @@ distinguished from a number. Use :c:func:`PyErr_Occurred` to disambiguate. The current implementation keeps an array of integer objects for all integers between ``-5`` and ``256``, when you create an int in that range you actually just get back a reference to the existing object. So it should be possible to - change the value of ``1``. I suspect the behaviour of Python in this case is - undefined. :-) + change the value of ``1``. .. c:function:: PyObject* PyLong_FromUnsignedLong(unsigned long v) From a16fd4b8e8603b14ec3e47f759bc377f799fc0d9 Mon Sep 17 00:00:00 2001 From: sgal <32255369+sgalal@users.noreply.github.com> Date: Mon, 15 Jul 2019 22:39:16 -0700 Subject: [PATCH 2/4] Remove another vague sentence A sentence starting with "So it should be possible..." shouldn't be in the docs either. Co-Authored-By: Kyle Stanley --- Doc/c-api/long.rst | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/Doc/c-api/long.rst b/Doc/c-api/long.rst index 19b04fc7b0b0cb..96c13b65988d6f 100644 --- a/Doc/c-api/long.rst +++ b/Doc/c-api/long.rst @@ -42,7 +42,7 @@ distinguished from a number. Use :c:func:`PyErr_Occurred` to disambiguate. The current implementation keeps an array of integer objects for all integers between ``-5`` and ``256``, when you create an int in that range you actually - just get back a reference to the existing object. So it should be possible to + just get back a reference to the existing object. change the value of ``1``. From 7e1dd4689b58556f79c80c109616e9f031ea3080 Mon Sep 17 00:00:00 2001 From: sgal <32255369+sgalal@users.noreply.github.com> Date: Mon, 15 Jul 2019 22:40:43 -0700 Subject: [PATCH 3/4] Include the removal of the previous line Co-Authored-By: Kyle Stanley --- Doc/c-api/long.rst | 1 - 1 file changed, 1 deletion(-) diff --git a/Doc/c-api/long.rst b/Doc/c-api/long.rst index 96c13b65988d6f..0358eda04543e5 100644 --- a/Doc/c-api/long.rst +++ b/Doc/c-api/long.rst @@ -43,7 +43,6 @@ distinguished from a number. Use :c:func:`PyErr_Occurred` to disambiguate. The current implementation keeps an array of integer objects for all integers between ``-5`` and ``256``, when you create an int in that range you actually just get back a reference to the existing object. - change the value of ``1``. .. c:function:: PyObject* PyLong_FromUnsignedLong(unsigned long v) From 040c2fda30f28af74bfdf8a0eecf981cc3f681b5 Mon Sep 17 00:00:00 2001 From: sgal <32255369+sgalal@users.noreply.github.com> Date: Mon, 15 Jul 2019 22:41:43 -0700 Subject: [PATCH 4/4] Remove an extra space --- Doc/c-api/long.rst | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/Doc/c-api/long.rst b/Doc/c-api/long.rst index 0358eda04543e5..aeebf3060eb4ed 100644 --- a/Doc/c-api/long.rst +++ b/Doc/c-api/long.rst @@ -42,7 +42,7 @@ distinguished from a number. Use :c:func:`PyErr_Occurred` to disambiguate. The current implementation keeps an array of integer objects for all integers between ``-5`` and ``256``, when you create an int in that range you actually - just get back a reference to the existing object. + just get back a reference to the existing object. .. c:function:: PyObject* PyLong_FromUnsignedLong(unsigned long v)