Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

bpo-37256: Wording in Request class docs #14792

Merged
merged 3 commits into from Aug 14, 2019

Conversation

@nsiregar
Copy link
Contributor

commented Jul 16, 2019

change wording in Request class documentation

https://bugs.python.org/issue37256

@aeros167
Copy link
Contributor

left a comment

@nsiregar Welcome and thanks for the contribution!

I definitely agree with the suggested changes. Since there are three additional arguments, it should be "next" instead of "last".

However, I would recommend making a small adjustment to the phrasing of the news entry to specify the module of the class, and use reST (markup language used by python docs):

Update Misc/NEWS.d/next/Documentation/2019-07-16-14-48-12.bpo-37256.q…
…JTrBb.rst

Co-Authored-By: Kyle Stanley <aeros167@gmail.com>
@CuriousLearner
Copy link
Contributor

left a comment

Wow, nice catch! 💯

LGTM 🌮

Thank you for your contribution @nsiregar

@CuriousLearner

This comment has been minimized.

Copy link
Contributor

commented Aug 13, 2019

Hiya @Mariatta @orsenthil

Can you please have a look at this one?

Thanks!

@orsenthil
Copy link
Member

left a comment

Thank you, Sanyam.

@orsenthil orsenthil merged commit 38c7199 into python:master Aug 14, 2019

5 checks passed

Azure Pipelines PR #20190717.7 succeeded
Details
bedevere/issue-number Issue number 37256 found
Details
bedevere/news News entry found in Misc/NEWS.d
continuous-integration/appveyor/pr AppVeyor build succeeded
Details
continuous-integration/travis-ci/pr The Travis CI build passed
Details
@bedevere-bot

This comment has been minimized.

Copy link

commented Aug 14, 2019

@orsenthil: Please replace # with GH- in the commit message next time. Thanks!

@miss-islington

This comment has been minimized.

Copy link

commented Aug 14, 2019

Thanks @nsiregar for the PR, and @orsenthil for merging it 🌮🎉.. I'm working now to backport this PR to: 3.7.
🐍🍒🤖

@miss-islington

This comment has been minimized.

Copy link

commented Aug 14, 2019

Thanks @nsiregar for the PR, and @orsenthil for merging it 🌮🎉.. I'm working now to backport this PR to: 3.8.
🐍🍒🤖

@bedevere-bot

This comment has been minimized.

Copy link

commented Aug 14, 2019

GH-15277 is a backport of this pull request to the 3.7 branch.

miss-islington added a commit to miss-islington/cpython that referenced this pull request Aug 14, 2019

bpo-37256: Wording in Request class docs (pythonGH-14792)
* bpo-37256: Wording in Request class docs

* 📜🤖 Added by blurb_it.

* Update Misc/NEWS.d/next/Documentation/2019-07-16-14-48-12.bpo-37256.qJTrBb.rst

Co-Authored-By: Kyle Stanley <aeros167@gmail.com>
(cherry picked from commit 38c7199)

Co-authored-by: Ngalim Siregar <ngalim.siregar@gmail.com>

miss-islington added a commit to miss-islington/cpython that referenced this pull request Aug 14, 2019

bpo-37256: Wording in Request class docs (pythonGH-14792)
* bpo-37256: Wording in Request class docs

* 📜🤖 Added by blurb_it.

* Update Misc/NEWS.d/next/Documentation/2019-07-16-14-48-12.bpo-37256.qJTrBb.rst

Co-Authored-By: Kyle Stanley <aeros167@gmail.com>
(cherry picked from commit 38c7199)

Co-authored-by: Ngalim Siregar <ngalim.siregar@gmail.com>
@bedevere-bot

This comment has been minimized.

Copy link

commented Aug 14, 2019

GH-15278 is a backport of this pull request to the 3.8 branch.

miss-islington added a commit that referenced this pull request Aug 14, 2019

bpo-37256: Wording in Request class docs (GH-14792)
* bpo-37256: Wording in Request class docs

* 📜🤖 Added by blurb_it.

* Update Misc/NEWS.d/next/Documentation/2019-07-16-14-48-12.bpo-37256.qJTrBb.rst

Co-Authored-By: Kyle Stanley <aeros167@gmail.com>
(cherry picked from commit 38c7199)

Co-authored-by: Ngalim Siregar <ngalim.siregar@gmail.com>

miss-islington added a commit that referenced this pull request Aug 16, 2019

bpo-37256: Wording in Request class docs (GH-14792)
* bpo-37256: Wording in Request class docs

* 📜🤖 Added by blurb_it.

* Update Misc/NEWS.d/next/Documentation/2019-07-16-14-48-12.bpo-37256.qJTrBb.rst

Co-Authored-By: Kyle Stanley <aeros167@gmail.com>
(cherry picked from commit 38c7199)

Co-authored-by: Ngalim Siregar <ngalim.siregar@gmail.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
8 participants
You can’t perform that action at this time.