From f67449d555254b2d4d04377ff81296f974fc82f3 Mon Sep 17 00:00:00 2001
From: kishorhange111 <kishorhange46@gmail.com>
Date: Sat, 25 Apr 2026 12:39:51 +0530
Subject: [PATCH 1/7] gh-148849: Deprecate http.cookies.BaseCookie.js_output()

---
 Doc/library/http.cookies.rst                  |  4 ++++
 Doc/whatsnew/3.15.rst                         |  6 +++++
 Lib/http/cookies.py                           |  5 +++++
 Lib/test/test_http_cookies.py                 | 22 ++++++++++++-------
 ...-04-25-12-04-27.gh-issue-148849.Vk6yEW.rst |  2 ++
 5 files changed, 31 insertions(+), 8 deletions(-)
 create mode 100644 Misc/NEWS.d/next/Library/2026-04-25-12-04-27.gh-issue-148849.Vk6yEW.rst

diff --git a/Doc/library/http.cookies.rst b/Doc/library/http.cookies.rst
index b3fcd21c7e2244..5b5d0418f167ef 100644
--- a/Doc/library/http.cookies.rst
+++ b/Doc/library/http.cookies.rst
@@ -109,6 +109,10 @@ Cookie Objects
 
    The meaning for *attrs* is the same as in :meth:`output`.
 
+   .. deprecated:: 3.15
+      :meth:`!js_output` is deprecated and will be removed in Python 3.17.
+      Use :meth:`output` instead.
+
 
 .. method:: BaseCookie.load(rawdata)
 
diff --git a/Doc/whatsnew/3.15.rst b/Doc/whatsnew/3.15.rst
index dbdd5de01700a3..a51e38e36d5a8b 100644
--- a/Doc/whatsnew/3.15.rst
+++ b/Doc/whatsnew/3.15.rst
@@ -1741,6 +1741,12 @@ New deprecations
     (Contributed by Bénédikt Tran in :gh:`134978`.)
 
 
+* :meth:`http.cookies.BaseCookie.js_output` is deprecated and will be
+  removed in Python 3.17. Use
+  :meth:`~http.cookies.BaseCookie.output` instead.
+  (Contributed by kishorhange111 in :gh:`148849`.)
+
+
 * :mod:`re`:
 
   * :func:`re.match` and :meth:`re.Pattern.match` are now
diff --git a/Lib/http/cookies.py b/Lib/http/cookies.py
index 660fec4f1be865..0bf2ebfce292a7 100644
--- a/Lib/http/cookies.py
+++ b/Lib/http/cookies.py
@@ -132,6 +132,7 @@
 import re
 import string
 import types
+import warnings
 
 __all__ = ["CookieError", "BaseCookie", "SimpleCookie"]
 
@@ -539,6 +540,10 @@ def __repr__(self):
             l.append('%s=%s' % (key, repr(value.value)))
         return '<%s: %s>' % (self.__class__.__name__, _spacejoin(l))
 
+    @warnings.deprecated(
+        "http.cookies.BaseCookie.js_output() is deprecated and will "
+        "be removed in Python 3.17; use output() instead"
+    )
     def js_output(self, attrs=None):
         """Return a string suitable for JavaScript."""
         result = []
diff --git a/Lib/test/test_http_cookies.py b/Lib/test/test_http_cookies.py
index cfcbc17bd6df80..1533e4755dd827 100644
--- a/Lib/test/test_http_cookies.py
+++ b/Lib/test/test_http_cookies.py
@@ -176,7 +176,8 @@ def test_load(self):
         self.assertEqual(C.output(['path']),
             'Set-Cookie: Customer="WILE_E_COYOTE"; Path=/acme')
         cookie_encoded = base64.b64encode(b'Customer="WILE_E_COYOTE"; Path=/acme; Version=1').decode('ascii')
-        self.assertEqual(C.js_output(), fr"""
+        with self.assertWarnsRegex(DeprecationWarning, "BaseCookie.js_output"):
+            self.assertEqual(C.js_output(), fr"""
         <script type="text/javascript">
         <!-- begin hiding
         document.cookie = atob("{cookie_encoded}");
@@ -184,7 +185,8 @@ def test_load(self):
         </script>
         """)
         cookie_encoded = base64.b64encode(b'Customer="WILE_E_COYOTE"; Path=/acme').decode('ascii')
-        self.assertEqual(C.js_output(['path']), fr"""
+        with self.assertWarnsRegex(DeprecationWarning, "BaseCookie.js_output"):
+            self.assertEqual(C.js_output(['path']), fr"""
         <script type="text/javascript">
         <!-- begin hiding
         document.cookie = atob("{cookie_encoded}");
@@ -293,7 +295,8 @@ def test_quoted_meta(self):
         self.assertEqual(C.output(['path']),
                          'Set-Cookie: Customer="WILE_E_COYOTE"; Path=/acme')
         expected_encoded_cookie = base64.b64encode(b'Customer=\"WILE_E_COYOTE\"; Path=/acme; Version=1').decode('ascii')
-        self.assertEqual(C.js_output(), fr"""
+        with self.assertWarnsRegex(DeprecationWarning, "BaseCookie.js_output"):
+            self.assertEqual(C.js_output(), fr"""
         <script type="text/javascript">
         <!-- begin hiding
         document.cookie = atob("{expected_encoded_cookie}");
@@ -301,7 +304,8 @@ def test_quoted_meta(self):
         </script>
         """)
         expected_encoded_cookie = base64.b64encode(b'Customer=\"WILE_E_COYOTE\"; Path=/acme').decode('ascii')
-        self.assertEqual(C.js_output(['path']), fr"""
+        with self.assertWarnsRegex(DeprecationWarning, "BaseCookie.js_output"):
+            self.assertEqual(C.js_output(['path']), fr"""
         <script type="text/javascript">
         <!-- begin hiding
         document.cookie = atob("{expected_encoded_cookie}");
@@ -672,16 +676,18 @@ def test_control_characters_output(self):
             morsel._key = c0  # Override private variable.
             cookie = cookies.SimpleCookie()
             cookie["cookie"] = morsel
-            with self.assertRaises(cookies.CookieError):
-                cookie.js_output()
+            with self.assertWarnsRegex(DeprecationWarning, "BaseCookie.js_output"):
+                with self.assertRaises(cookies.CookieError):
+                    cookie.js_output()
 
             morsel = cookies.Morsel()
             morsel.set("key", "value", "coded-value")
             morsel._coded_value = c0  # Override private variable.
             cookie = cookies.SimpleCookie()
             cookie["cookie"] = morsel
-            with self.assertRaises(cookies.CookieError):
-                cookie.js_output()
+            with self.assertWarnsRegex(DeprecationWarning, "BaseCookie.js_output"):
+                with self.assertRaises(cookies.CookieError):
+                    cookie.js_output()
 
 
 def load_tests(loader, tests, pattern):
diff --git a/Misc/NEWS.d/next/Library/2026-04-25-12-04-27.gh-issue-148849.Vk6yEW.rst b/Misc/NEWS.d/next/Library/2026-04-25-12-04-27.gh-issue-148849.Vk6yEW.rst
new file mode 100644
index 00000000000000..a92471f62e56c8
--- /dev/null
+++ b/Misc/NEWS.d/next/Library/2026-04-25-12-04-27.gh-issue-148849.Vk6yEW.rst
@@ -0,0 +1,2 @@
+Deprecate :meth:`http.cookies.BaseCookie.js_output`, which will be
+removed in Python 3.17. Use :meth:`http.cookies.BaseCookie.output` instead.

From d1e4a57f8080ac87a891d7b02052fe6d952a8f23 Mon Sep 17 00:00:00 2001
From: kishorhange111 <101962449+kishorhange111@users.noreply.github.com>
Date: Sat, 25 Apr 2026 08:22:02 +0000
Subject: [PATCH 2/7] Address review comments

---
 Doc/deprecations/pending-removal-in-3.19.rst | 10 ++++++++++
 Doc/library/http.cookies.rst                 |  2 +-
 Doc/whatsnew/3.15.rst                        |  4 +++-
 Lib/http/cookies.py                          |  9 +++++----
 Lib/test/test_http_cookies.py                | 12 ++++++------
 5 files changed, 25 insertions(+), 12 deletions(-)

diff --git a/Doc/deprecations/pending-removal-in-3.19.rst b/Doc/deprecations/pending-removal-in-3.19.rst
index 25f9cba390de68..08ba13e851ef6a 100644
--- a/Doc/deprecations/pending-removal-in-3.19.rst
+++ b/Doc/deprecations/pending-removal-in-3.19.rst
@@ -22,3 +22,13 @@ Pending removal in Python 3.19
     supported depending on the backend implementation of hash functions.
     Prefer passing the initial data as a positional argument for maximum
     backwards compatibility.
+
+* :mod:`http.cookies`:
+
+  * :meth:`http.cookies.BaseCookie.js_output` is deprecated and will be
+    removed in Python 3.19.
+
+    This method generates a JavaScript snippet to set cookies in the browser,
+    which is no longer considered a standard or recommended approach.
+    Use :meth:`~http.cookies.BaseCookie.output` instead to generate HTTP
+    headers.
diff --git a/Doc/library/http.cookies.rst b/Doc/library/http.cookies.rst
index 5b5d0418f167ef..76a2ca4f7dd601 100644
--- a/Doc/library/http.cookies.rst
+++ b/Doc/library/http.cookies.rst
@@ -110,7 +110,7 @@ Cookie Objects
    The meaning for *attrs* is the same as in :meth:`output`.
 
    .. deprecated:: 3.15
-      :meth:`!js_output` is deprecated and will be removed in Python 3.17.
+      :meth:`!js_output` is deprecated and will be removed in Python 3.19.
       Use :meth:`output` instead.
 
 
diff --git a/Doc/whatsnew/3.15.rst b/Doc/whatsnew/3.15.rst
index a51e38e36d5a8b..0fb7f3f1c30c76 100644
--- a/Doc/whatsnew/3.15.rst
+++ b/Doc/whatsnew/3.15.rst
@@ -1741,8 +1741,10 @@ New deprecations
     (Contributed by Bénédikt Tran in :gh:`134978`.)
 
 
+* :mod:`http.cookies`
+
 * :meth:`http.cookies.BaseCookie.js_output` is deprecated and will be
-  removed in Python 3.17. Use
+  removed in Python 3.19. Use
   :meth:`~http.cookies.BaseCookie.output` instead.
   (Contributed by kishorhange111 in :gh:`148849`.)
 
diff --git a/Lib/http/cookies.py b/Lib/http/cookies.py
index 0bf2ebfce292a7..9573cafaecf67e 100644
--- a/Lib/http/cookies.py
+++ b/Lib/http/cookies.py
@@ -540,11 +540,12 @@ def __repr__(self):
             l.append('%s=%s' % (key, repr(value.value)))
         return '<%s: %s>' % (self.__class__.__name__, _spacejoin(l))
 
-    @warnings.deprecated(
-        "http.cookies.BaseCookie.js_output() is deprecated and will "
-        "be removed in Python 3.17; use output() instead"
-    )
     def js_output(self, attrs=None):
+        warnings._deprecated(
+            "http.cookies.BaseCookie.js_output",
+            "3.19",
+            "Use output() instead"
+        )
         """Return a string suitable for JavaScript."""
         result = []
         items = sorted(self.items())
diff --git a/Lib/test/test_http_cookies.py b/Lib/test/test_http_cookies.py
index 1533e4755dd827..0e11baa902a8ac 100644
--- a/Lib/test/test_http_cookies.py
+++ b/Lib/test/test_http_cookies.py
@@ -176,7 +176,7 @@ def test_load(self):
         self.assertEqual(C.output(['path']),
             'Set-Cookie: Customer="WILE_E_COYOTE"; Path=/acme')
         cookie_encoded = base64.b64encode(b'Customer="WILE_E_COYOTE"; Path=/acme; Version=1').decode('ascii')
-        with self.assertWarnsRegex(DeprecationWarning, "BaseCookie.js_output"):
+        with self.assertWarnsRegex(DeprecationWarning, r"BaseCookie\.js_output"):
             self.assertEqual(C.js_output(), fr"""
         <script type="text/javascript">
         <!-- begin hiding
@@ -185,7 +185,7 @@ def test_load(self):
         </script>
         """)
         cookie_encoded = base64.b64encode(b'Customer="WILE_E_COYOTE"; Path=/acme').decode('ascii')
-        with self.assertWarnsRegex(DeprecationWarning, "BaseCookie.js_output"):
+        with self.assertWarnsRegex(DeprecationWarning, r"BaseCookie\.js_output"):
             self.assertEqual(C.js_output(['path']), fr"""
         <script type="text/javascript">
         <!-- begin hiding
@@ -295,7 +295,7 @@ def test_quoted_meta(self):
         self.assertEqual(C.output(['path']),
                          'Set-Cookie: Customer="WILE_E_COYOTE"; Path=/acme')
         expected_encoded_cookie = base64.b64encode(b'Customer=\"WILE_E_COYOTE\"; Path=/acme; Version=1').decode('ascii')
-        with self.assertWarnsRegex(DeprecationWarning, "BaseCookie.js_output"):
+        with self.assertWarnsRegex(DeprecationWarning, r"BaseCookie\.js_output"):
             self.assertEqual(C.js_output(), fr"""
         <script type="text/javascript">
         <!-- begin hiding
@@ -304,7 +304,7 @@ def test_quoted_meta(self):
         </script>
         """)
         expected_encoded_cookie = base64.b64encode(b'Customer=\"WILE_E_COYOTE\"; Path=/acme').decode('ascii')
-        with self.assertWarnsRegex(DeprecationWarning, "BaseCookie.js_output"):
+        with self.assertWarnsRegex(DeprecationWarning, r"BaseCookie\.js_output"):
             self.assertEqual(C.js_output(['path']), fr"""
         <script type="text/javascript">
         <!-- begin hiding
@@ -676,7 +676,7 @@ def test_control_characters_output(self):
             morsel._key = c0  # Override private variable.
             cookie = cookies.SimpleCookie()
             cookie["cookie"] = morsel
-            with self.assertWarnsRegex(DeprecationWarning, "BaseCookie.js_output"):
+            with self.assertWarnsRegex(DeprecationWarning, r"BaseCookie\.js_output"):
                 with self.assertRaises(cookies.CookieError):
                     cookie.js_output()
 
@@ -685,7 +685,7 @@ def test_control_characters_output(self):
             morsel._coded_value = c0  # Override private variable.
             cookie = cookies.SimpleCookie()
             cookie["cookie"] = morsel
-            with self.assertWarnsRegex(DeprecationWarning, "BaseCookie.js_output"):
+            with self.assertWarnsRegex(DeprecationWarning, r"BaseCookie\.js_output"):
                 with self.assertRaises(cookies.CookieError):
                     cookie.js_output()
 

From 627fa9bd0f38a5fef945d294165377380e3a0d7f Mon Sep 17 00:00:00 2001
From: kishorhange111 <101962449+kishorhange111@users.noreply.github.com>
Date: Sat, 25 Apr 2026 08:52:45 +0000
Subject: [PATCH 3/7] Version updated to 3.19

---
 .../next/Library/2026-04-25-12-04-27.gh-issue-148849.Vk6yEW.rst | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

diff --git a/Misc/NEWS.d/next/Library/2026-04-25-12-04-27.gh-issue-148849.Vk6yEW.rst b/Misc/NEWS.d/next/Library/2026-04-25-12-04-27.gh-issue-148849.Vk6yEW.rst
index a92471f62e56c8..7f1f708e36040b 100644
--- a/Misc/NEWS.d/next/Library/2026-04-25-12-04-27.gh-issue-148849.Vk6yEW.rst
+++ b/Misc/NEWS.d/next/Library/2026-04-25-12-04-27.gh-issue-148849.Vk6yEW.rst
@@ -1,2 +1,2 @@
 Deprecate :meth:`http.cookies.BaseCookie.js_output`, which will be
-removed in Python 3.17. Use :meth:`http.cookies.BaseCookie.output` instead.
+removed in Python 3.19. Use :meth:`http.cookies.BaseCookie.output` instead.

From 60cf501f2c9176fb6eb81ce6e32af8df87519fb4 Mon Sep 17 00:00:00 2001
From: kishorhange111 <101962449+kishorhange111@users.noreply.github.com>
Date: Sat, 25 Apr 2026 09:08:43 +0000
Subject: [PATCH 4/7] Fix deprecation warning implementation

---
 Lib/http/cookies.py | 9 +++++----
 1 file changed, 5 insertions(+), 4 deletions(-)

diff --git a/Lib/http/cookies.py b/Lib/http/cookies.py
index 9573cafaecf67e..93eae7058afcc4 100644
--- a/Lib/http/cookies.py
+++ b/Lib/http/cookies.py
@@ -541,10 +541,11 @@ def __repr__(self):
         return '<%s: %s>' % (self.__class__.__name__, _spacejoin(l))
 
     def js_output(self, attrs=None):
-        warnings._deprecated(
-            "http.cookies.BaseCookie.js_output",
-            "3.19",
-            "Use output() instead"
+        warnings.warn(
+            "http.cookies.BaseCookie.js_output() is deprecated and will "
+            "be removed in Python 3.19; use output() instead",
+            DeprecationWarning,
+            stacklevel=2,
         )
         """Return a string suitable for JavaScript."""
         result = []

From 964c27fe2db520863c1e24a550fb63396a389066 Mon Sep 17 00:00:00 2001
From: kishorhange111 <101962449+kishorhange111@users.noreply.github.com>
Date: Sat, 25 Apr 2026 14:45:16 +0530
Subject: [PATCH 5/7] Update Doc/library/http.cookies.rst

Co-authored-by: Stan Ulbrych <stan@python.org>
---
 Doc/library/http.cookies.rst | 3 +--
 1 file changed, 1 insertion(+), 2 deletions(-)

diff --git a/Doc/library/http.cookies.rst b/Doc/library/http.cookies.rst
index 76a2ca4f7dd601..b946bed0d65c4c 100644
--- a/Doc/library/http.cookies.rst
+++ b/Doc/library/http.cookies.rst
@@ -109,8 +109,7 @@ Cookie Objects
 
    The meaning for *attrs* is the same as in :meth:`output`.
 
-   .. deprecated:: 3.15
-      :meth:`!js_output` is deprecated and will be removed in Python 3.19.
+   .. deprecated-removed:: next 3.19
       Use :meth:`output` instead.
 
 

From 3d31227337f8be50c985a48b54c549b116606341 Mon Sep 17 00:00:00 2001
From: kishorhange111 <101962449+kishorhange111@users.noreply.github.com>
Date: Sat, 25 Apr 2026 15:09:51 +0530
Subject: [PATCH 6/7] Update Doc/whatsnew/3.15.rst
MIME-Version: 1.0
Content-Type: text/plain; charset=UTF-8
Content-Transfer-Encoding: 8bit

Co-authored-by: Bénédikt Tran <10796600+picnixz@users.noreply.github.com>
---
 Doc/whatsnew/3.15.rst | 10 +++++-----
 1 file changed, 5 insertions(+), 5 deletions(-)

diff --git a/Doc/whatsnew/3.15.rst b/Doc/whatsnew/3.15.rst
index 0fb7f3f1c30c76..87709ce63d393e 100644
--- a/Doc/whatsnew/3.15.rst
+++ b/Doc/whatsnew/3.15.rst
@@ -1741,12 +1741,12 @@ New deprecations
     (Contributed by Bénédikt Tran in :gh:`134978`.)
 
 
-* :mod:`http.cookies`
+* :mod:`http.cookies`:
 
-* :meth:`http.cookies.BaseCookie.js_output` is deprecated and will be
-  removed in Python 3.19. Use
-  :meth:`~http.cookies.BaseCookie.output` instead.
-  (Contributed by kishorhange111 in :gh:`148849`.)
+  * :meth:`BaseCookie.js_output <http.cookies.BaseCookie.js_output>` is deprecated
+    and will be removed in Python 3.19. Use :meth:`BaseCookie.output
+    <http.cookies.BaseCookie.output>` instead.
+    (Contributed by kishorhange111 in :gh:`148849`.)
 
 
 * :mod:`re`:

From b169fc8545263653de9f68a0ded312d1aee707c1 Mon Sep 17 00:00:00 2001
From: kishorhange111 <101962449+kishorhange111@users.noreply.github.com>
Date: Sat, 25 Apr 2026 10:06:09 +0000
Subject: [PATCH 7/7] Fix deprecation warning message to match tests

---
 Lib/http/cookies.py           | 9 ++++-----
 Lib/test/test_http_cookies.py | 9 +++++----
 2 files changed, 9 insertions(+), 9 deletions(-)

diff --git a/Lib/http/cookies.py b/Lib/http/cookies.py
index 93eae7058afcc4..97bf670a319aab 100644
--- a/Lib/http/cookies.py
+++ b/Lib/http/cookies.py
@@ -541,11 +541,10 @@ def __repr__(self):
         return '<%s: %s>' % (self.__class__.__name__, _spacejoin(l))
 
     def js_output(self, attrs=None):
-        warnings.warn(
-            "http.cookies.BaseCookie.js_output() is deprecated and will "
-            "be removed in Python 3.19; use output() instead",
-            DeprecationWarning,
-            stacklevel=2,
+        warnings._deprecated(
+            "http.cookies.BaseCookie.js_output",
+            remove=(3, 19),
+            message="http.cookies.BaseCookie.js_output() is deprecated, use output() instead",
         )
         """Return a string suitable for JavaScript."""
         result = []
diff --git a/Lib/test/test_http_cookies.py b/Lib/test/test_http_cookies.py
index 0e11baa902a8ac..6b6f64841ba0cc 100644
--- a/Lib/test/test_http_cookies.py
+++ b/Lib/test/test_http_cookies.py
@@ -676,8 +676,8 @@ def test_control_characters_output(self):
             morsel._key = c0  # Override private variable.
             cookie = cookies.SimpleCookie()
             cookie["cookie"] = morsel
-            with self.assertWarnsRegex(DeprecationWarning, r"BaseCookie\.js_output"):
-                with self.assertRaises(cookies.CookieError):
+            with self.assertRaises(cookies.CookieError):
+                with self.assertWarnsRegex(DeprecationWarning, r"BaseCookie\.js_output"):
                     cookie.js_output()
 
             morsel = cookies.Morsel()
@@ -685,11 +685,12 @@ def test_control_characters_output(self):
             morsel._coded_value = c0  # Override private variable.
             cookie = cookies.SimpleCookie()
             cookie["cookie"] = morsel
-            with self.assertWarnsRegex(DeprecationWarning, r"BaseCookie\.js_output"):
-                with self.assertRaises(cookies.CookieError):
+            with self.assertRaises(cookies.CookieError):
+                with self.assertWarnsRegex(DeprecationWarning, r"BaseCookie\.js_output"):
                     cookie.js_output()
 
 
+
 def load_tests(loader, tests, pattern):
     tests.addTest(doctest.DocTestSuite(cookies))
     return tests