Skip to content

gh-151130: Add more tests for PyWeakref_* C API#151131

Merged
serhiy-storchaka merged 2 commits into
python:mainfrom
serhiy-storchaka:test_capi-test_weakref
Jun 9, 2026
Merged

gh-151130: Add more tests for PyWeakref_* C API#151131
serhiy-storchaka merged 2 commits into
python:mainfrom
serhiy-storchaka:test_capi-test_weakref

Conversation

@serhiy-storchaka

@serhiy-storchaka serhiy-storchaka commented Jun 9, 2026 •
edited by bedevere-app Bot
Loading

Copy link
Copy Markdown
Member

@serhiy-storchaka serhiy-storchaka requested a review from vstinner June 9, 2026 08:56
@serhiy-storchaka serhiy-storchaka added the tests Tests in the Lib/test dir label Jun 9, 2026
@serhiy-storchaka serhiy-storchaka requested a review from itamaro as a code owner June 9, 2026 08:57
@serhiy-storchaka serhiy-storchaka added needs backport to 3.13 bugs and security fixes needs backport to 3.14 bugs and security fixes needs backport to 3.15 pre-release feature fixes, bugs and security fixes labels Jun 9, 2026
@bedevere-app bedevere-app Bot mentioned this pull request Jun 9, 2026
Open
vstinner
vstinner approved these changes Jun 9, 2026
View reviewed changes

@vstinner vstinner left a comment

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM. I just have some suggestions.

Comment thread Lib/test/test_capi/test_weakref.py
Comment thread Lib/test/test_capi/test_weakref.py
Comment thread Modules/_testlimitedcapi/weakref.c Outdated
@serhiy-storchaka @vstinner
Apply suggestions from code review
de38336 
Co-authored-by: Victor Stinner <vstinner@python.org>
@serhiy-storchaka

serhiy-storchaka commented Jun 9, 2026

Copy link
Copy Markdown
Member Author

Thank you for your review, @vstinner.

@serhiy-storchaka serhiy-storchaka enabled auto-merge (squash) June 9, 2026 10:48
@serhiy-storchaka serhiy-storchaka merged commit c3cd75a into python:main Jun 9, 2026
55 checks passed
@miss-islington-app

miss-islington-app Bot commented Jun 9, 2026

Copy link
Copy Markdown

Thanks @serhiy-storchaka for the PR 🌮🎉.. I'm working now to backport this PR to: 3.13, 3.14, 3.15.
🐍🍒⛏🤖

@miss-islington-app

miss-islington-app Bot commented Jun 9, 2026

Copy link
Copy Markdown

Sorry, @serhiy-storchaka, I could not cleanly backport this to 3.14 due to a conflict.
Please backport using cherry_picker on command line.

cherry_picker c3cd75afdf86f6a811663c71da22cc24c784a6f4 3.14

@miss-islington-app

miss-islington-app Bot commented Jun 9, 2026

Copy link
Copy Markdown

Sorry, @serhiy-storchaka, I could not cleanly backport this to 3.13 due to a conflict.
Please backport using cherry_picker on command line.

cherry_picker c3cd75afdf86f6a811663c71da22cc24c784a6f4 3.13

@bedevere-app

bedevere-app Bot commented Jun 9, 2026

Copy link
Copy Markdown

GH-151140 is a backport of this pull request to the 3.15 branch.

@bedevere-app bedevere-app Bot removed the needs backport to 3.15 pre-release feature fixes, bugs and security fixes label Jun 9, 2026
@serhiy-storchaka serhiy-storchaka deleted the test_capi-test_weakref branch June 9, 2026 11:12
@bedevere-app

bedevere-app Bot commented Jun 9, 2026

Copy link
Copy Markdown

GH-151141 is a backport of this pull request to the 3.14 branch.

@bedevere-app bedevere-app Bot removed the needs backport to 3.14 bugs and security fixes label Jun 9, 2026
@serhiy-storchaka serhiy-storchaka removed the needs backport to 3.13 bugs and security fixes label Jun 9, 2026
@serhiy-storchaka serhiy-storchaka removed their assignment Jun 9, 2026
serhiy-storchaka added a commit that referenced this pull request Jun 9, 2026
@miss-islington @serhiy-storchaka
[3.15] gh-151130: Add more tests for PyWeakref_* C API (GH-151131) (G…
2d432f2 
…H-151140)

(cherry picked from commit c3cd75a)

Co-authored-by: Serhiy Storchaka <storchaka@gmail.com>
serhiy-storchaka added a commit that referenced this pull request Jun 9, 2026
@serhiy-storchaka
[3.14] gh-151130: Add more tests for PyWeakref_* C API (GH-151131) (G…
cb96d5e 
…H-151141)

(cherry picked from commit c3cd75a)
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@vstinner vstinner vstinner approved these changes

@kumaraditya303 kumaraditya303 Awaiting requested review from kumaraditya303 kumaraditya303 is a code owner

@erlend-aasland erlend-aasland Awaiting requested review from erlend-aasland erlend-aasland is a code owner

@AA-Turner AA-Turner Awaiting requested review from AA-Turner AA-Turner is a code owner

@emmatyping emmatyping Awaiting requested review from emmatyping emmatyping is a code owner

@itamaro itamaro Awaiting requested review from itamaro itamaro is a code owner

Assignees

No one assigned

Labels

tests Tests in the Lib/test dir

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

2 participants

@serhiy-storchaka @vstinner