Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

bpo-37758: Clean out vestigial script-bits from test_unicodedata. #15126

Merged
merged 1 commit into from Aug 13, 2019

Conversation

@gnprice
Copy link
Contributor

commented Aug 5, 2019

This file started life as a script, before conversion to a
unittest test file. Clear out some legacies of that conversion
that are a bit confusing about how it works.

Most notably, it's unlikely there's still a good reason to try
to recover from unicodedata failing to import -- as there was
when that logic was first added, when the module was very new.
So take that out entirely. Keep self.db working, though, to
avoid a noisy diff.

https://bugs.python.org/issue37758

bpo-37758: Clean out vestigial script-bits from test_unicodedata.
This file started life as a script, before conversion to a
`unittest` test file.  Clear out some legacies of that conversion
that are a bit confusing about how it works.

Most notably, it's unlikely there's still a good reason to try
to recover from `unicodedata` failing to import -- as there was
when that logic was first added, when the module was very new.
So take that out entirely.  Keep `self.db` working, though, to
avoid a noisy diff.

@benjaminp benjaminp added the skip news label Aug 13, 2019

@benjaminp benjaminp merged commit def97c9 into python:master Aug 13, 2019

5 checks passed

Azure Pipelines PR #20190805.2 succeeded
Details
bedevere/issue-number Issue number 37758 found
Details
bedevere/news "skip news" label found
continuous-integration/appveyor/pr AppVeyor build succeeded
Details
continuous-integration/travis-ci/pr The Travis CI build passed
Details

@gnprice gnprice deleted the gnprice:pr-unicodedata-spruce-tests branch Aug 13, 2019

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
4 participants
You can’t perform that action at this time.