Navigation Menu

Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

test_locale.py: correct the test output format #15132

Closed
wants to merge 1 commit into from

Conversation

code-share1
Copy link

Before this patch:

python3 -m test -v test_locale

[snip]
test_getsetlocale_issue1813 (test.test_locale.TestMiscellaneous) ... testing with ('tr_TR', 'ISO8859-9') ok
[snip]

After this patch:

python3 -m test -v test_locale

[snip]
test_getsetlocale_issue1813 (test.test_locale.TestMiscellaneous) ... testing with ('tr_TR', 'ISO8859-9')... ok
[snip]

Make the test ended with "... ok" is common in python
unittest world, we should make it keep consistent
with other test cases in case it may be ignored to
record in the report if we use the common filter
"... ok".

Signed-off-by: Mingli Yu mingli.yu@windriver.com

Before this patch:
 # python3 -m test -v test_locale
 [snip]
 test_getsetlocale_issue1813 (test.test_locale.TestMiscellaneous) ... testing with ('tr_TR', 'ISO8859-9') ok
 [snip]

 After this patch:
 # python3 -m test -v test_locale
 [snip]
 test_getsetlocale_issue1813 (test.test_locale.TestMiscellaneous) ... testing with ('tr_TR', 'ISO8859-9')... ok
 [snip]

Make the test ended with "... ok" is common in python
unittest world, we should make it keep consistent
with other test cases in case it may be ignored to
record in the report if we use the common filter
"... ok".

Signed-off-by: Mingli Yu <mingli.yu@windriver.com>
@the-knights-who-say-ni
Copy link

Hello, and thanks for your contribution!

I'm a bot set up to make sure that the project can legally accept your contribution by verifying you have signed the PSF contributor agreement (CLA).

Unfortunately we couldn't find an account corresponding to your GitHub username on bugs.python.org (b.p.o) to verify you have signed the CLA (this might be simply due to a missing "GitHub Name" entry in your b.p.o account settings). This is necessary for legal reasons before we can look at your contribution. Please follow the steps outlined in the CPython devguide to rectify this issue.

You can check yourself to see if the CLA has been received.

Thanks again for your contribution, we look forward to reviewing it!

@zware
Copy link
Member

zware commented Sep 10, 2019

Hi @code-share1. I'd like to accept this patch, but we should really have a signed CLA from you to do so. Would you be willing to follow the instructions in the comment from @the-knights-who-say-ni?

@csabella
Copy link
Contributor

@code-share1, please sign the CLA for your change to be accepted. If you're unable to do this, we'll have to close your PR.

@csabella
Copy link
Contributor

csabella commented Jan 5, 2020

@code-share1, I'm sorry, but I'm going to close this pull request as the CLA hasn't been signed yet. If you are able to sign the CLA, then we can re-open the PR at that time. Thank you for your interest in improving CPython.

@csabella csabella closed this Jan 5, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

5 participants