Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

bpo-25810: Clarify eval() docs, it does not keywords (GH-15173) #15173

Merged
merged 1 commit into from Sep 11, 2019

Conversation

@smokephil
Copy link
Contributor

commented Aug 8, 2019

bpo-25810: Clarify eval() docs, it does not keywords (GH-15173)

https://bugs.python.org/issue25810

@the-knights-who-say-ni

This comment has been minimized.

Copy link

commented Aug 8, 2019

Hello, and thanks for your contribution!

I'm a bot set up to make sure that the project can legally accept your contribution by verifying you have signed the PSF contributor agreement (CLA).

Unfortunately we couldn't find an account corresponding to your GitHub username on bugs.python.org (b.p.o) to verify you have signed the CLA (this might be simply due to a missing "GitHub Name" entry in your b.p.o account settings). This is necessary for legal reasons before we can look at your contribution. Please follow the steps outlined in the CPython devguide to rectify this issue.

You can check yourself to see if the CLA has been received.

Thanks again for your contribution, we look forward to reviewing it!

@aeros167
Copy link
Member

left a comment

Welcome and thanks for the contribution!

Based on the comment from R. David Murray:

I think we are moving toward using (and documenting in the main docs) the / notation. Especially since it shows up in the inspect module as well as the docstring help.

as well as the rest of the discussion on the issue, I think it would be more appropriate to use the / notation:

Doc/library/functions.rst Show resolved Hide resolved

@gpshead gpshead self-assigned this Sep 10, 2019

@gpshead gpshead changed the title bpo-25810: fix documentation for eval() call bpo-25810: Clarify eval() docs, it does not keywords (GH-15173) Sep 11, 2019

@gpshead gpshead merged commit 7a0023e into python:master Sep 11, 2019

5 checks passed

Azure Pipelines PR #20190808.6 succeeded
Details
bedevere/issue-number Issue number 25810 found
Details
bedevere/news "skip news" label found
continuous-integration/appveyor/pr AppVeyor build succeeded
Details
continuous-integration/travis-ci/pr The Travis CI build passed
Details
@miss-islington

This comment has been minimized.

Copy link

commented Sep 11, 2019

Thanks @smokephil for the PR, and @gpshead for merging it 🌮🎉.. I'm working now to backport this PR to: 3.7, 3.8.
🐍🍒🤖

miss-islington added a commit to miss-islington/cpython that referenced this pull request Sep 11, 2019
bpo-25810: Clarify eval() docs, it does not keywords (pythonGH-15173)
(cherry picked from commit 7a0023e)

Co-authored-by: smokephil <smokephil@gmail.com>
@bedevere-bot

This comment has been minimized.

Copy link

commented Sep 11, 2019

GH-15910 is a backport of this pull request to the 3.8 branch.

miss-islington added a commit to miss-islington/cpython that referenced this pull request Sep 11, 2019
bpo-25810: Clarify eval() docs, it does not keywords (pythonGH-15173)
(cherry picked from commit 7a0023e)

Co-authored-by: smokephil <smokephil@gmail.com>
@bedevere-bot

This comment has been minimized.

Copy link

commented Sep 11, 2019

GH-15911 is a backport of this pull request to the 3.7 branch.

miss-islington added a commit that referenced this pull request Sep 11, 2019
bpo-25810: Clarify eval() docs, it does not keywords (GH-15173)
(cherry picked from commit 7a0023e)

Co-authored-by: smokephil <smokephil@gmail.com>
miss-islington added a commit that referenced this pull request Sep 11, 2019
bpo-25810: Clarify eval() docs, it does not keywords (GH-15173)
(cherry picked from commit 7a0023e)

Co-authored-by: smokephil <smokephil@gmail.com>
vrpolakatcisco added a commit to vrpolakatcisco/cpython that referenced this pull request Sep 12, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
6 participants
You can’t perform that action at this time.