Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

bpo-37759: Second round of edits to Whatsnew 3.8 #15204

Merged
merged 12 commits into from Aug 12, 2019

Conversation

@rhettinger
Copy link
Contributor

commented Aug 11, 2019

Work in progress. Please add suggestions here as you find them.

https://bugs.python.org/issue37759

https://bugs.python.org/issue37759

@rhettinger rhettinger requested a review from willingc Aug 12, 2019

Doc/whatsnew/3.8.rst Outdated Show resolved Hide resolved
@willingc
Copy link
Contributor

left a comment

LGTM with one small nit. Thanks @rhettinger.

@rhettinger rhettinger merged commit 66a34d3 into python:master Aug 12, 2019

5 checks passed

Azure Pipelines PR #20190812.33 succeeded
Details
bedevere/issue-number Issue number 37759 found
Details
bedevere/news "skip news" label found
continuous-integration/appveyor/pr AppVeyor build succeeded
Details
continuous-integration/travis-ci/pr The Travis CI build passed
Details

@rhettinger rhettinger deleted the rhettinger:better_whatsnew_round_two branch Aug 12, 2019

@miss-islington

This comment has been minimized.

Copy link

commented Aug 12, 2019

Thanks @rhettinger for the PR 🌮🎉.. I'm working now to backport this PR to: 3.8.
🐍🍒🤖

@miss-islington

This comment has been minimized.

Copy link

commented Aug 12, 2019

Sorry, @rhettinger, I could not cleanly backport this to 3.8 due to a conflict.
Please backport using cherry_picker on command line.
cherry_picker 66a34d35e4c97da9840a29ba9fba76721021c463 3.8

@rhettinger rhettinger restored the rhettinger:better_whatsnew_round_two branch Aug 12, 2019

@miss-islington

This comment has been minimized.

Copy link

commented Aug 12, 2019

Thanks @rhettinger for the PR 🌮🎉.. I'm working now to backport this PR to: 3.8.
🐍🍒🤖

@miss-islington

This comment has been minimized.

Copy link

commented Aug 12, 2019

Sorry @rhettinger, I had trouble checking out the 3.8 backport branch.
Please backport using cherry_picker on command line.
cherry_picker 66a34d35e4c97da9840a29ba9fba76721021c463 3.8

@miss-islington

This comment has been minimized.

Copy link

commented Aug 12, 2019

Thanks @rhettinger for the PR 🌮🎉.. I'm working now to backport this PR to: 3.8.
🐍🍒🤖

@miss-islington

This comment has been minimized.

Copy link

commented Aug 12, 2019

Sorry, @rhettinger, I could not cleanly backport this to 3.8 due to a conflict.
Please backport using cherry_picker on command line.
cherry_picker 66a34d35e4c97da9840a29ba9fba76721021c463 3.8

@miss-islington

This comment has been minimized.

Copy link

commented Aug 13, 2019

Thanks @rhettinger for the PR 🌮🎉.. I'm working now to backport this PR to: 3.8.
🐍🍒🤖

@miss-islington

This comment has been minimized.

Copy link

commented Aug 13, 2019

Sorry @rhettinger, I had trouble checking out the 3.8 backport branch.
Please backport using cherry_picker on command line.
cherry_picker 66a34d35e4c97da9840a29ba9fba76721021c463 3.8

rhettinger added a commit to rhettinger/cpython that referenced this pull request Aug 13, 2019

@bedevere-bot

This comment has been minimized.

Copy link

commented Aug 13, 2019

GH-15240 is a backport of this pull request to the 3.8 branch.

rhettinger added a commit that referenced this pull request Aug 13, 2019

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
6 participants
You can’t perform that action at this time.