Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

bpo-37845: Fixed SSLCertVerificationError when Certifications are published with DNS Names that may start with white spaces #15260

Closed
wants to merge 2 commits into from

Conversation

@DK26
Copy link

commented Aug 13, 2019

bpo-37845:
Fixed: SSLCertVerificationError("partial wildcards in leftmost label are not supported: ' *.x.y.com'.")
by invoking strip() on dn (Domain Name) object when _dnsname_match() is performed.

In a big company, the certification publish process may be out of the hand of the programmer.
In my case, only my App had this problem while all other none-python Apps didn't suffer the same.

SecOps wouldn't republish fixed certifications because of white spaces in DNS names that my Python App wouldn't handle.

https://bugs.python.org/issue37845

Fixed issue 37845: SSLCertVerificationError("partial wildcards in lef…
…tmost label are not supported: ' *.x.y.com'.")

by invoking strip() on dn (Domain Name) object.

@DK26 DK26 requested a review from tiran as a code owner Aug 13, 2019

@the-knights-who-say-ni

This comment has been minimized.

Copy link

commented Aug 13, 2019

Hello, and thanks for your contribution!

I'm a bot set up to make sure that the project can legally accept your contribution by verifying you have signed the PSF contributor agreement (CLA).

Our records indicate we have not received your CLA. For legal reasons we need you to sign this before we can look at your contribution. Please follow the steps outlined in the CPython devguide to rectify this issue.

If you have recently signed the CLA, please wait at least one business day
before our records are updated.

You can check yourself to see if the CLA has been received.

Thanks again for your contribution, we look forward to reviewing it!

@tiran tiran added the invalid label Aug 14, 2019

@tiran

This comment has been minimized.

Copy link
Member

commented Aug 14, 2019

The change is not acceptable.

@tiran tiran closed this Aug 14, 2019

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
4 participants
You can’t perform that action at this time.