Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

bpo-37915: Fix comparison between tzinfo objects and timezone objects #15390

Merged
merged 5 commits into from Aug 22, 2019
Merged

bpo-37915: Fix comparison between tzinfo objects and timezone objects #15390

merged 5 commits into from Aug 22, 2019

Conversation

pablogsal
Copy link
Member

@pablogsal pablogsal commented Aug 22, 2019 •
edited by miss-islington

pganssle
pganssle requested changes Aug 22, 2019
View reviewed changes
Lib/test/datetimetester.py Show resolved Hide resolved
Misc/NEWS.d/next/Library/2019-08-22-16-13-27.bpo-37915.xyoZI5.rst Outdated Show resolved Hide resolved
Modules/_datetimemodule.c Show resolved Hide resolved
@bedevere-bot
Copy link

When you're done making the requested changes, leave the comment: I have made the requested changes; please review again.

@pablogsal @pganssle
Update Misc/NEWS.d/next/Library/2019-08-22-16-13-27.bpo-37915.xyoZI5.rst
0ea14fc 
Co-Authored-By: Paul Ganssle <pganssle@users.noreply.github.com>
@pablogsal
Copy link
Member Author

I have made the requested changes; please review again

@bedevere-bot
Copy link

Thanks for making the requested changes!

@pganssle: please review the changes made to this pull request.

@tirkarthi
Copy link
Member

3.7 also has this change with 6ed20e5 and would require a backport. Thanks Pablo for the fix.

@miss-islington miss-islington merged commit 4be11c0 into python:master Aug 22, 2019
@miss-islington
Copy link
Contributor

Thanks @pablogsal for the PR 🌮🎉.. I'm working now to backport this PR to: 3.7, 3.8.
🐍🍒⛏🤖

@bedevere-bot
Copy link

GH-15399 is a backport of this pull request to the 3.8 branch.

@bedevere-bot bedevere-bot removed the needs backport to 3.8 only security fixes label Aug 22, 2019
@miss-islington
Copy link
Contributor

Sorry, @pablogsal, I could not cleanly backport this to 3.7 due to a conflict.
Please backport using cherry_picker on command line.
cherry_picker 4be11c009abe88175fa164b45e4838e7267dfa97 3.7

miss-islington pushed a commit to miss-islington/cpython that referenced this pull request Aug 22, 2019
@pablogsal @miss-islington
bpo-37915: Fix comparison between tzinfo objects and timezone objects (…
86e857a 
…pythonGH-15390)

https://bugs.python.org/issue37915

Automerge-Triggered-By: @pablogsal
(cherry picked from commit 4be11c0)

Co-authored-by: Pablo Galindo <Pablogsal@gmail.com>
@miss-islington miss-islington self-assigned this Aug 22, 2019
miss-islington added a commit that referenced this pull request Aug 23, 2019
@miss-islington @pablogsal
bpo-37915: Fix comparison between tzinfo objects and timezone objects (…
5c77730 
…GH-15390)

https://bugs.python.org/issue37915

Automerge-Triggered-By: @pablogsal
(cherry picked from commit 4be11c0)

Co-authored-by: Pablo Galindo <Pablogsal@gmail.com>
@pablogsal pablogsal deleted the bpo-37915 branch August 23, 2019 09:51
@bedevere-bot
Copy link

GH-15417 is a backport of this pull request to the 3.7 branch.

pablogsal added a commit to pablogsal/cpython that referenced this pull request Aug 23, 2019
@pablogsal
[3.7] bpo-37915: Fix comparison between tzinfo objects and timezone o…
c5c873f 
…bjects (pythonGH-15390)

https://bugs.python.org/issue37915

Automerge-Triggered-By: @pablogsal.
(cherry picked from commit 4be11c0)

Co-authored-by: Pablo Galindo <Pablogsal@gmail.com>
pablogsal added a commit that referenced this pull request Aug 23, 2019
@pablogsal
[3.7] bpo-37915: Fix comparison between tzinfo objects and timezone o…
1b1796d 
…bjects (GH-15390) (GH-15417)

https://bugs.python.org/issue37915

Automerge-Triggered-By: @pablogsal.
(cherry picked from commit 4be11c0)

Co-authored-by: Pablo Galindo <Pablogsal@gmail.com>
@TomAugspurger TomAugspurger mentioned this pull request Aug 23, 2019
Merged
lisroach pushed a commit to lisroach/cpython that referenced this pull request Sep 10, 2019
@pablogsal @lisroach
bpo-37915: Fix comparison between tzinfo objects and timezone objects (…
5966fd6 
…pythonGH-15390)

https://bugs.python.org/issue37915



Automerge-Triggered-By: @pablogsal
DinoV pushed a commit to DinoV/cpython that referenced this pull request Jan 14, 2020
@pablogsal @DinoV
bpo-37915: Fix comparison between tzinfo objects and timezone objects (…
5928f09 
…pythonGH-15390)

https://bugs.python.org/issue37915



Automerge-Triggered-By: @pablogsal
websurfer5 pushed a commit to websurfer5/cpython that referenced this pull request Jul 20, 2020
@pablogsal @websurfer5
bpo-37915: Fix comparison between tzinfo objects and timezone objects (…
6bb543d 
…pythonGH-15390)

https://bugs.python.org/issue37915



Automerge-Triggered-By: @pablogsal
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@serhiy-storchaka serhiy-storchaka serhiy-storchaka approved these changes

@abalkin abalkin Awaiting requested review from abalkin

@pganssle pganssle Awaiting requested review from pganssle

Assignees

@miss-islington miss-islington

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
7 participants
@pablogsal @bedevere-bot @tirkarthi @miss-islington @pganssle @serhiy-storchaka @the-knights-who-say-ni