Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

bpo-36309 pydoc.py: line 1533 - updated mktemp to mkstemp #15640

Open
wants to merge 1 commit into
base: master
from

Conversation

@fuzzygwalchmei
Copy link

commented Sep 2, 2019

line 1533 - updated mktemp to mkstemp

https://bugs.python.org/issue36309

line 1533 - updated mktemp to mkstemp
@the-knights-who-say-ni

This comment has been minimized.

Copy link

commented Sep 2, 2019

Hello, and thanks for your contribution!

I'm a bot set up to make sure that the project can legally accept your contribution by verifying you have signed the PSF contributor agreement (CLA).

Unfortunately we couldn't find an account corresponding to your GitHub username on bugs.python.org (b.p.o) to verify you have signed the CLA (this might be simply due to a missing "GitHub Name" entry in your b.p.o account settings). This is necessary for legal reasons before we can look at your contribution. Please follow the steps outlined in the CPython devguide to rectify this issue.

You can check yourself to see if the CLA has been received.

Thanks again for your contribution, we look forward to reviewing it!

@tirkarthi

This comment has been minimized.

Copy link
Contributor

commented Sep 2, 2019

Since there is no decision reached on the issue and mailing list I am not sure if this needs a separate PR. Perhaps this could be done as part of the PR where warning is raised and all the relevant call sites are also changed with several places where this function is used.

@tonybaloney

This comment has been minimized.

Copy link
Contributor

commented Sep 3, 2019

@tirkarthi this pr is regarding an individual use of the mktemp() call, not to suppress it completely. The recommendation in the stdlib is to replace calls to mktemp() with one of the alternatives
The pydoc module uses mktemp() for some local caching. This was the only occurrence in the stdlib.

@tonybaloney

This comment has been minimized.

Copy link
Contributor

commented Sep 3, 2019

The linked BPO is incorrect, this should probably have it's own bpo

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
5 participants
You can’t perform that action at this time.