bpo-38073: Make pwd module PEP-384 compatible #15790
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
matrixise
requested changes
Sep 9, 2019
Misc/NEWS.d/next/Core and Builtins/2019-09-09-15-17-58.bpo-38073.ZoKYOU.rst
Outdated
Show resolved
Hide resolved
|
When you're done making the requested changes, leave the comment: |
DinoV
changed the title
|
I have made the requested changes; please review again. |
|
Thanks for making the requested changes! @matrixise: please review the changes made to this pull request. |
tiran
requested changes
Sep 10, 2019
| @@ -0,0 +1 @@ | |||
| `:mod:`pwd` is :pep:`384` compatible | |||
There was a problem hiding this comment.
sphinx doesn't like the reference here, please change the text to Make pwd extension module PEP-384 compatible
|
When you're done making the requested changes, leave the comment: |
tiran
approved these changes
Sep 10, 2019
|
@DinoV: Status check is done, and it's a success ✅ . |
websurfer5
pushed a commit
to websurfer5/cpython
that referenced
this pull request
Jul 20, 2020
Makes the pwd module PEP-384 compatible https://bugs.python.org/issue38073 Automerge-Triggered-By: @tiran
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Makes the pwd module PEP-384 compatible
https://bugs.python.org/issue38073
Automerge-Triggered-By: @tiran