Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[3.8] bpo-37424: Avoid a hang in subprocess.run timeout output capture (GH-14490) #15897

Merged
merged 1 commit into from Sep 11, 2019

Conversation

@miss-islington
Copy link

commented Sep 11, 2019

Fixes a possible hang when using a timeout on subprocess.run() while
capturing output. If the child process spawned its own children or otherwise
connected its stdout or stderr handles with another process, we could hang
after the timeout was reached and our child was killed when attempting to read
final output from the pipes.
(cherry picked from commit 580d278)

Co-authored-by: Gregory P. Smith greg@krypto.org

https://bugs.python.org/issue37424

bpo-37424: Avoid a hang in subprocess.run timeout output capture (GH-…
…14490)

Fixes a possible hang when using a timeout on subprocess.run() while
capturing output. If the child process spawned its own children or otherwise
connected its stdout or stderr handles with another process, we could hang
after the timeout was reached and our child was killed when attempting to read
final output from the pipes.
(cherry picked from commit 580d278)

Co-authored-by: Gregory P. Smith <greg@krypto.org>
@miss-islington

This comment has been minimized.

Copy link
Author

commented Sep 11, 2019

@gpshead and @Yhg1s: Status check is done, and it's a success .

1 similar comment
@miss-islington

This comment has been minimized.

Copy link
Author

commented Sep 11, 2019

@gpshead and @Yhg1s: Status check is done, and it's a success .

@miss-islington miss-islington merged commit 872c85a into python:3.8 Sep 11, 2019

6 checks passed

Azure Pipelines PR #20190911.25 succeeded
Details
bedevere/issue-number Issue number 37424 found
Details
bedevere/maintenance-branch-pr Valid maintenance branch PR title.
bedevere/news News entry found in Misc/NEWS.d
continuous-integration/appveyor/pr AppVeyor build succeeded
Details
continuous-integration/travis-ci/pr The Travis CI build passed
Details

@miss-islington miss-islington deleted the miss-islington:backport-580d278-3.8 branch Sep 11, 2019

@miss-islington

This comment has been minimized.

Copy link
Author

commented Sep 11, 2019

@gpshead and @Yhg1s: Status check is done, and it's a success .

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
4 participants
You can’t perform that action at this time.