Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

bpo-36634: Fixes activate.bat when existing values contain double quotes #15924

Merged
merged 2 commits into from Sep 11, 2019

Conversation

@zooba
Copy link
Member

commented Sep 11, 2019

@zware
zware approved these changes Sep 11, 2019
Copy link
Member

left a comment

LGTM

@zware zware merged commit 574b324 into python:master Sep 11, 2019

5 checks passed

Azure Pipelines PR #20190911.100 succeeded
Details
bedevere/issue-number Issue number 36634 found
Details
bedevere/news News entry found in Misc/NEWS.d
continuous-integration/appveyor/pr AppVeyor build succeeded
Details
continuous-integration/travis-ci/pr The Travis CI build passed
Details
@miss-islington

This comment has been minimized.

Copy link

commented Sep 11, 2019

Thanks @zooba for the PR, and @zware for merging it 🌮🎉.. I'm working now to backport this PR to: 3.7, 3.8.
🐍🍒🤖

@zooba zooba deleted the zooba:bpo-36634 branch Sep 11, 2019

miss-islington added a commit to miss-islington/cpython that referenced this pull request Sep 11, 2019
bpo-36634: Fixes activate.bat when existing values contain double quo…
…tes (pythonGH-15924)

(cherry picked from commit 574b324)

Co-authored-by: Steve Dower <steve.dower@python.org>
@bedevere-bot

This comment has been minimized.

Copy link

commented Sep 11, 2019

GH-15968 is a backport of this pull request to the 3.8 branch.

@bedevere-bot

This comment has been minimized.

Copy link

commented Sep 11, 2019

GH-15969 is a backport of this pull request to the 3.7 branch.

miss-islington added a commit to miss-islington/cpython that referenced this pull request Sep 11, 2019
bpo-36634: Fixes activate.bat when existing values contain double quo…
…tes (pythonGH-15924)

(cherry picked from commit 574b324)

Co-authored-by: Steve Dower <steve.dower@python.org>
miss-islington added a commit that referenced this pull request Sep 11, 2019
bpo-36634: Fixes activate.bat when existing values contain double quo…
…tes (GH-15924)

(cherry picked from commit 574b324)

Co-authored-by: Steve Dower <steve.dower@python.org>
miss-islington added a commit that referenced this pull request Sep 11, 2019
bpo-36634: Fixes activate.bat when existing values contain double quo…
…tes (GH-15924)

(cherry picked from commit 574b324)

Co-authored-by: Steve Dower <steve.dower@python.org>
vrpolakatcisco added a commit to vrpolakatcisco/cpython that referenced this pull request Sep 12, 2019
DinoV added a commit to DinoV/cpython that referenced this pull request Sep 12, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
5 participants
You can’t perform that action at this time.