Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

bpo-33166: Change os.cpu_count to return active (real) processors #15949

Merged
merged 3 commits into from Sep 11, 2019

Conversation

@zooba
Copy link
Member

commented Sep 11, 2019

@zooba

This comment has been minimized.

Copy link
Member Author

commented Sep 11, 2019

Note that I added the prototype rather than changing the Windows version in pyconfig.h. This is so it's safe to backport to 3.8.

In a later PR I'll update the API version.

Modules/posixmodule.c Show resolved Hide resolved
@bedevere-bot

This comment has been minimized.

Copy link

commented Sep 11, 2019

When you're done making the requested changes, leave the comment: I have made the requested changes; please review again.

@zooba

This comment has been minimized.

Copy link
Member Author

commented Sep 11, 2019

I don't want to backport the WINNT_VER change because we have so much stuff that tries to auto-detect macros, and that may introduce new macros. It's a little late in the release cycle for that.

@zooba

This comment has been minimized.

Copy link
Member Author

commented Sep 11, 2019

I have made the requested changes; please review again

Ping @zware

@zware
zware approved these changes Sep 11, 2019
Copy link
Member

left a comment

LGTM

@zware zware merged commit aa92927 into python:master Sep 11, 2019

4 checks passed

Azure Pipelines PR #20190911.153 succeeded
Details
bedevere/issue-number Issue number 33166 found
Details
bedevere/news News entry found in Misc/NEWS.d
continuous-integration/travis-ci/pr The Travis CI build passed
Details
@miss-islington

This comment has been minimized.

Copy link

commented Sep 11, 2019

Thanks @zooba for the PR, and @zware for merging it 🌮🎉.. I'm working now to backport this PR to: 3.8.
🐍🍒🤖

miss-islington added a commit to miss-islington/cpython that referenced this pull request Sep 11, 2019
bpo-33166: Change os.cpu_count to return active (real) processors (py…
…thonGH-15949)

(cherry picked from commit aa92927)

Co-authored-by: Steve Dower <steve.dower@python.org>
@bedevere-bot

This comment has been minimized.

Copy link

commented Sep 11, 2019

GH-15979 is a backport of this pull request to the 3.8 branch.

@zooba zooba deleted the zooba:bpo-33166 branch Sep 11, 2019

miss-islington added a commit that referenced this pull request Sep 11, 2019
bpo-33166: Change os.cpu_count to return active (real) processors (GH…
…-15949)

(cherry picked from commit aa92927)

Co-authored-by: Steve Dower <steve.dower@python.org>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
5 participants
You can’t perform that action at this time.