Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

bpo-32592: Set Windows 8 as the minimum required version for API support #15951

Merged
merged 3 commits into from Sep 11, 2019

Conversation

@zooba
Copy link
Member

commented Sep 11, 2019

@zooba zooba added the OS-windows label Sep 11, 2019

@zooba zooba requested a review from python/windows-team as a code owner Sep 11, 2019

@zware

This comment has been minimized.

Copy link
Member

commented Sep 11, 2019

This is going to require a change to the buildbot config to turn off the 3.x builder on the Windows 7 bot(s). I'd rather wait on this until that change is in than to have to make the change to fix the breakage.

@zooba

This comment has been minimized.

Copy link
Member Author

commented Sep 11, 2019

It shouldn't, as the minimum API isn't actually enforced anywhere except at compile time, and all the Win10 SDKs have the Win8 APIs available.

@zware

This comment has been minimized.

Copy link
Member

commented Sep 11, 2019

I've started a buildbot-custom build to check that.

@zooba

This comment has been minimized.

Copy link
Member Author

commented Sep 11, 2019

Don't merge this before #15949 or it'll break the other one. (That PR is being backported, and then I'll have to rebase this one...)

@zooba zooba added the DO-NOT-MERGE label Sep 11, 2019

@zware

This comment has been minimized.

Copy link
Member

commented Sep 11, 2019

The Win7 SP1 buildbot is happy, so I'll merge this after #15949.

@zooba zooba removed the DO-NOT-MERGE label Sep 11, 2019

@zware
zware approved these changes Sep 11, 2019

@zware zware merged commit 0b72ccf into python:master Sep 11, 2019

4 checks passed

Azure Pipelines PR #20190911.184 succeeded
Details
bedevere/issue-number Issue number 32592 found
Details
bedevere/news News entry found in Misc/NEWS.d
continuous-integration/travis-ci/pr The Travis CI build passed
Details

@zooba zooba deleted the zooba:bpo-32592 branch Sep 11, 2019

@vstinner

This comment has been minimized.

Copy link
Member

commented Sep 11, 2019

Thanks!

vrpolakatcisco added a commit to vrpolakatcisco/cpython that referenced this pull request Sep 12, 2019
DinoV added a commit to DinoV/cpython that referenced this pull request Sep 12, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
5 participants
You can’t perform that action at this time.