Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We鈥檒l occasionally send you account related emails.

Already on GitHub? Sign in to your account

[3.8] bpo-37972: unittest.mock._Call now passes on __getitem__ to the __getattr__ chaining so that call() can be subscriptable (GH-15565) #15965

Merged
merged 1 commit into from Sep 12, 2019

Conversation

@miss-islington
Copy link

commented Sep 11, 2019

  • bpo-37972: unittest.mock._Call now passes on getitem to the getattr chaining so that call() can be subscriptable

  • 馃摐馃 Added by blurb_it.

  • Update 2019-08-28-21-40-12.bpo-37972.kP-n4L.rst

added name of the contributor

  • bpo-37972: made all dunder methods chainable for _Call

  • bpo-37972: delegate only attributes of tuple instead to getattr
    (cherry picked from commit 72c3599)

Co-authored-by: blhsing github@ydooby.com

https://bugs.python.org/issue37972

bpo-37972: unittest.mock._Call now passes on __getitem__ to the __get鈥
鈥ttr__ chaining so that call() can be subscriptable (GH-15565)

* bpo-37972: unittest.mock._Call now passes on __getitem__ to the __getattr__ chaining so that call() can be subscriptable

* 馃摐馃 Added by blurb_it.

* Update 2019-08-28-21-40-12.bpo-37972.kP-n4L.rst

added name of the contributor

* bpo-37972: made all dunder methods chainable for _Call

* bpo-37972: delegate only attributes of tuple instead to __getattr__
(cherry picked from commit 72c3599)

Co-authored-by: blhsing <github@ydooby.com>
@voidspace
Copy link
Contributor

left a comment

LGTM

@voidspace voidspace merged commit db0d8a5 into python:3.8 Sep 12, 2019

5 of 6 checks passed

continuous-integration/appveyor/pr Waiting for AppVeyor build to complete
Details
Azure Pipelines PR #20190911.160 succeeded
Details
bedevere/issue-number Issue number 37972 found
Details
bedevere/maintenance-branch-pr Valid maintenance branch PR title.
bedevere/news News entry found in Misc/NEWS.d
continuous-integration/travis-ci/pr The Travis CI build passed
Details

@miss-islington miss-islington deleted the miss-islington:backport-72c3599-3.8 branch Sep 12, 2019

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
5 participants
You can鈥檛 perform that action at this time.