Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[3.8] bpo-37885: venv: Don't produce unbound variable warning on deactivate (GH-15330) #15973

Merged
merged 1 commit into from Sep 11, 2019

Conversation

miss-islington
Copy link
Contributor

@miss-islington miss-islington commented Sep 11, 2019

Before, running deactivate from a bash shell configured to treat undefined variables as errors (set -u) would produce a warning:

$ python3 -m venv test
$ source test/bin/activate
(test) $ deactivate
-bash: $1: unbound variable

(cherry picked from commit 5209e58)

Co-authored-by: Daniel Abrahamsson hamsson@gmail.com

https://bugs.python.org/issue37885

…pythonGH-15330)

Before, running deactivate from a bash shell configured to treat undefined variables as errors (`set -u`) would produce a warning:

```
$ python3 -m venv test
$ source test/bin/activate
(test) $ deactivate
-bash: $1: unbound variable
```
(cherry picked from commit 5209e58)

Co-authored-by: Daniel Abrahamsson <hamsson@gmail.com>
@miss-islington
Copy link
Contributor Author

@danabr and @Yhg1s: Status check is done, and it's a success ✅ .

@Yhg1s Yhg1s merged commit 63eefc3 into python:3.8 Sep 11, 2019
@miss-islington miss-islington deleted the backport-5209e58-3.8 branch September 11, 2019 15:56
@miss-islington
Copy link
Contributor Author

@danabr and @Yhg1s: Status check is done, and it's a success ✅ .

1 similar comment
@miss-islington
Copy link
Contributor Author

@danabr and @Yhg1s: Status check is done, and it's a success ✅ .

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

5 participants