Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

bpo-38108: Makes mock objects inherit from Base #16060

Merged
merged 6 commits into from Sep 29, 2019
Merged

Conversation

@lisroach
Copy link
Contributor

lisroach commented Sep 12, 2019

Updates the few Mock classes that do not inherit from Base to properly inherit from base. Updates the super() calls that should go with them as well.

That was all I planned on doing with this diff, but the changes to get AsyncMock inheritance working right with subclasses was so linked with this diff I merged it into one to prevent temporary breaking changes.

https://bugs.python.org/issue38108

Copy link
Contributor

asvetlov left a comment

LGTM

@lisroach lisroach requested review from gvanrossum, ilevkivskyi, tiran and python/windows-team as code owners Sep 27, 2019
@lisroach

This comment has been minimized.

Copy link
Contributor Author

lisroach commented Sep 27, 2019

Oops, didn't mean to do that

@lisroach lisroach force-pushed the lisroach:issue38108 branch from f4cbc87 to 94f0c8d Sep 27, 2019
@lisroach lisroach removed request for python/windows-team, tiran, gvanrossum and ilevkivskyi Sep 27, 2019
@lisroach lisroach merged commit 9a7d951 into python:master Sep 29, 2019
4 checks passed
4 checks passed
Azure Pipelines PR #20190927.32 succeeded
Details
bedevere/issue-number Issue number 38108 found
Details
bedevere/news News entry found in Misc/NEWS.d
continuous-integration/travis-ci/pr The Travis CI build passed
Details
@lisroach lisroach deleted the lisroach:issue38108 branch Sep 29, 2019
@miss-islington

This comment has been minimized.

Copy link

miss-islington commented Sep 29, 2019

Thanks @lisroach for the PR 🌮🎉.. I'm working now to backport this PR to: 3.8.
🐍🍒🤖

miss-islington added a commit to miss-islington/cpython that referenced this pull request Sep 29, 2019
(cherry picked from commit 9a7d951)

Co-authored-by: Lisa Roach <lisaroach14@gmail.com>
@bedevere-bot

This comment has been minimized.

Copy link

bedevere-bot commented Sep 29, 2019

GH-16470 is a backport of this pull request to the 3.8 branch.

lisroach added a commit that referenced this pull request Sep 30, 2019
jacobneiltaylor added a commit to jacobneiltaylor/cpython that referenced this pull request Dec 5, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
5 participants
You can’t perform that action at this time.