Skip to content

Conversation

@zooba
Copy link
Member

@zooba zooba commented May 17, 2017

This allows VS 2015 or VS 2017 with Python support installed to open all the standard library files.

@zooba zooba added the trivial label May 17, 2017
@mention-bot
Copy link

@zooba, thanks for your PR! By analyzing the history of the files in this pull request, we identified @briancurtin, @amauryfa and @shibturn to be potential reviewers.

@zooba
Copy link
Member Author

zooba commented May 17, 2017

VS 2015 (and to a much lesser extent, VS 2017) will hit memory issues if you load the project, so removing it from the solution. It's still there for people to load if they want.

@zooba
Copy link
Member Author

zooba commented May 17, 2017

Also, we tested the version number changes in the solution file and they don't impact VS 2015.

@zooba zooba merged commit 78e25ab into python:master May 17, 2017
@zooba zooba deleted the lib-pyproj branch May 17, 2017 20:06
@terryjreedy
Copy link
Member

The commit message is a bit confusing as it says that lib.pyproj was added to and then deleted from 'solution' for a net null effect. Reading the commit, it seems that the actual effect is

  • Add 1000+ lines to a new or existing PCbuild/lib.pyproj.
  • Update Visual Studio version in PCbuild/pcbuild.sln.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

5 participants