Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[3.8] bpo-38006: Clear weakrefs in garbage found by the GC (GH-16495) #16499

Merged
merged 1 commit into from Sep 30, 2019

Conversation

@miss-islington
Copy link

miss-islington commented Sep 30, 2019

Fix a bug due to the interaction of weakrefs and the cyclic garbage
collector. We must clear any weakrefs in garbage in order to prevent
their callbacks from executing and causing a crash.
(cherry picked from commit bcda460)

Co-authored-by: Neil Schemenauer nas-github@arctrix.com

https://bugs.python.org/issue38006

Fix a bug due to the interaction of weakrefs and the cyclic garbage
collector. We must clear any weakrefs in garbage in order to prevent
their callbacks from executing and causing a crash.
(cherry picked from commit bcda460)

Co-authored-by: Neil Schemenauer <nas-github@arctrix.com>
@ambv ambv changed the title [3.8] Clear weakrefs in garbage found by the GC (GH-16495) [3.8] bpo-38006: Clear weakrefs in garbage found by the GC (GH-16495) Sep 30, 2019
@miss-islington

This comment has been minimized.

Copy link
Author

miss-islington commented Sep 30, 2019

@nascheme and @ambv: Status check is done, and it's a success .

@ambv ambv merged commit 92ca515 into python:3.8 Sep 30, 2019
5 checks passed
5 checks passed
Azure Pipelines PR #20190930.40 succeeded
Details
bedevere/issue-number Issue number 38006 found
Details
bedevere/maintenance-branch-pr Valid maintenance branch PR title.
bedevere/news News entry found in Misc/NEWS.d
continuous-integration/travis-ci/pr The Travis CI build passed
Details
@bedevere-bot

This comment has been minimized.

Copy link

bedevere-bot commented Sep 30, 2019

@ambv: Please replace # with GH- in the commit message next time. Thanks!

@miss-islington miss-islington deleted the miss-islington:backport-bcda460-3.8 branch Sep 30, 2019
@miss-islington

This comment has been minimized.

Copy link
Author

miss-islington commented Sep 30, 2019

@nascheme and @ambv: Status check is done, and it's a success .

1 similar comment
@miss-islington

This comment has been minimized.

Copy link
Author

miss-islington commented Sep 30, 2019

@nascheme and @ambv: Status check is done, and it's a success .

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
5 participants
You can’t perform that action at this time.