Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[3.8] bpo-33418: Restore tp_clear for function object #16502

Merged
merged 1 commit into from Oct 1, 2019
Merged

[3.8] bpo-33418: Restore tp_clear for function object #16502

merged 1 commit into from Oct 1, 2019

Conversation

nascheme
Copy link
Member

@nascheme nascheme commented Sep 30, 2019 •
edited by bedevere-bot

This is a revert of the revert (GH-15826, ccaea52). Having a tp_clear for
functions should be safe (and helpful) now that bpo-38006 has been fixed.

https://bugs.python.org/issue33418

@nascheme
Restore tp_clear for function object.
8cbe5ae 
This is a revert of the revert (pythonGH-15826).  Having a tp_clear for
functions should be safe (and helpful) now that bpo-38006 has been
fixed.
@nascheme nascheme requested a review from ambv September 30, 2019 20:46
tim-one
tim-one approved these changes Oct 1, 2019
View reviewed changes
Copy link
Member

@tim-one tim-one left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

@ambv ambv changed the title [3.8] Restore tp_clear for function object. [3.8] bpo-33418: Restore tp_clear for function object Oct 1, 2019
@ambv ambv removed the skip issue label Oct 1, 2019
@ambv
Copy link
Contributor

ambv commented Oct 1, 2019

For reference:

  • this has never been reverted on master (3c45240 is still active there) so it doesn't need a "forward-port" there
  • this feature has been there for all published prereleases of 3.8 so it's pretty well covered with tests, it's safe to restore it now

@ambv ambv merged commit b361207 into python:3.8 Oct 1, 2019
@bedevere-bot
Copy link

@ambv: Please replace # with GH- in the commit message next time. Thanks!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@tim-one tim-one tim-one approved these changes

@ambv ambv Awaiting requested review from ambv

Assignees
No one assigned
Labels
skip news
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
5 participants
@nascheme @ambv @bedevere-bot @tim-one @the-knights-who-say-ni