Navigation Menu

Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

bpo-38345: Added end lines to pyclbr objects #16534

Closed
wants to merge 3 commits into from
Closed

bpo-38345: Added end lines to pyclbr objects #16534

wants to merge 3 commits into from

Conversation

robertkearns
Copy link

@robertkearns robertkearns commented Oct 2, 2019

Added the end lines to each object. Useful for users who wish to determine the scope of a class/function to determine dependencies.

https://bugs.python.org/issue38345

Added the end lines to each object. Useful for users who wish to determine the scope of a class/function to determine dependencies.
@the-knights-who-say-ni
Copy link

Hello, and thanks for your contribution!

I'm a bot set up to make sure that the project can legally accept this contribution by verifying everyone involved has signed the PSF contributor agreement (CLA).

CLA Missing

Our records indicate the following people have not signed the CLA:

@robertkearns

For legal reasons we need all the people listed to sign the CLA before we can look at your contribution. Please follow the steps outlined in the CPython devguide to rectify this issue.

If you have recently signed the CLA, please wait at least one business day
before our records are updated.

You can check yourself to see if the CLA has been received.

Thanks again for the contribution, we look forward to reviewing it!

Copy link
Member

@terryjreedy terryjreedy left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Some of the formatting changes are correct, some merely distracting, and some wrong.

An acceptable patch would need the tests revised to test the revised output.

"""Smart list, which adds the ending line of a class/function when it
is removed from the stack (when its scope has ended).
"""
def __init__(self):
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

list.init optionally populates the empty list returned by list.new. This subclass init with no parameters does nothing and therefore should not be included.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants