Skip to content

bpo-38468 : Refactor python-config #16749

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 7 commits into from
Oct 15, 2019
Merged

bpo-38468 : Refactor python-config #16749

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
7 commits
Select commit Hold shift + click to select a range
a17da60
refactor python-config
nanjekyejoannah Oct 13, 2019
9cf1aad
📜🤖 Added by blurb_it.
blurb-it[bot] Oct 13, 2019
06ec9df
Update Misc/NEWS.d/next/Build/2019-10-13-16-18-24.bpo-38468.buCO84.rst
nanjekyejoannah Oct 14, 2019
bd551b8
Use getvar for pyver
nanjekyejoannah Oct 14, 2019
58b35df
Update news entry with affected file.
nanjekyejoannah Oct 15, 2019
b6dd121
Update Misc/NEWS.d/next/Build/2019-10-13-16-18-24.bpo-38468.buCO84.rst
nanjekyejoannah Oct 15, 2019
8f7e334
Update 2019-10-13-16-18-24.bpo-38468.buCO84.rst
nanjekyejoannah Oct 15, 2019
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 2 additions & 0 deletions Misc/NEWS.d/next/Build/2019-10-13-16-18-24.bpo-38468.buCO84.rst
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -0,0 +1,2 @@
Misc/python-config.in now uses `getvar()` for all still existing `sysconfig.get_config_var()` calls.
Patch by Joannah Nanjekye.
10 changes: 5 additions & 5 deletions Misc/python-config.in
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -25,8 +25,8 @@ except getopt.error:
if not opts:
exit_with_usage()

pyver = sysconfig.get_config_var('VERSION')
getvar = sysconfig.get_config_var
pyver = getvar('VERSION')

opt_flags = [flag for (flag, val) in opts]

Expand All @@ -35,10 +35,10 @@ if '--help' in opt_flags:

for opt in opt_flags:
if opt == '--prefix':
print(sysconfig.get_config_var('prefix'))
print(getvar('prefix'))

elif opt == '--exec-prefix':
print(sysconfig.get_config_var('exec_prefix'))
print(getvar('exec_prefix'))

elif opt in ('--includes', '--cflags'):
flags = ['-I' + sysconfig.get_path('include'),
Expand All @@ -65,10 +65,10 @@ for opt in opt_flags:
print(' '.join(libs))

elif opt == '--extension-suffix':
print(sysconfig.get_config_var('EXT_SUFFIX'))
print(getvar('EXT_SUFFIX'))

elif opt == '--abiflags':
print(sys.abiflags)

elif opt == '--configdir':
print(sysconfig.get_config_var('LIBPL'))
print(getvar('LIBPL'))