Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

bpo-26128: Added __init__to STARTUPINFO #171

Merged
merged 1 commit into from Feb 25, 2017

Conversation

Projects
None yet
6 participants
@codenamesubho
Copy link
Contributor

commented Feb 19, 2017

No description provided.

@the-knights-who-say-ni

This comment has been minimized.

Copy link

commented Feb 19, 2017

Hello, and thanks for your contribution!

I'm a bot set up to make sure that the project can legally accept your contribution by verifying you have signed the PSF contributor agreement (CLA).

Unfortunately our records indicate you have not signed the CLA. For legal reasons we need you to sign this before we can look at your contribution. Please follow these steps to rectify the issue:

  1. Sign the PSF contributor agreement
  2. Wait at least one US business day and then check "Your Details" on bugs.python.org to see if your account has been marked as having signed the CLA (the delay is due to a person having to manually check your signed CLA)
  3. Reply here saying you have completed the above steps

Thanks again to your contribution and we look forward to looking at it!

hStdOutput = None
hStdError = None
wShowWindow = 0
def __init__(self,dwFlags=0,hStdInput=None,hStdOutput=None,

This comment has been minimized.

Copy link
@sayanchowdhury

sayanchowdhury Feb 19, 2017

Contributor

This needs to be implemented via keyword only arguments as the Terry suggested in the issue.

This comment has been minimized.

Copy link
@sayanchowdhury

sayanchowdhury Feb 19, 2017

Contributor

.. and spaces after the args

@codenamesubho codenamesubho force-pushed the codenamesubho:bpo-26128 branch from f3f03b5 to 6ace239 Feb 19, 2017

@ncoghlan ncoghlan force-pushed the codenamesubho:bpo-26128 branch from 6ace239 to 9d884b7 Feb 23, 2017

@ncoghlan ncoghlan self-assigned this Feb 23, 2017

@ncoghlan

This comment has been minimized.

Copy link
Contributor

commented Feb 23, 2017

OK, I've figured out how to push updates back to PR branches (hence the rebase atop the master branch), so next step will be to add the bookkeeping updates (ACKS, NEWS, What's New) and then merge the change.

@codenamesubho codenamesubho force-pushed the codenamesubho:bpo-26128 branch from 9d884b7 to 767ae22 Feb 23, 2017

@codenamesubho

This comment has been minimized.

Copy link
Contributor Author

commented Feb 24, 2017

so next step will be to add the bookkeeping updates (ACKS, NEWS, What's New) and then merge the change.

@ncoghlan , Anymore changes I need to do for this patch?

@codenamesubho codenamesubho force-pushed the codenamesubho:bpo-26128 branch 2 times, most recently from 0ceb455 to c668fb4 Feb 25, 2017

bpo-26128: Added __init__to STARTUPINFO
- Added tests for the code
- Added docs

@codenamesubho codenamesubho force-pushed the codenamesubho:bpo-26128 branch from c668fb4 to 03d755f Feb 25, 2017

@codenamesubho

This comment has been minimized.

Copy link
Contributor Author

commented Feb 25, 2017

@ncoghlan Added Acks and News, wasn't sure what to write in "What's New". Letme know if anything is missing. Thanks.

@ncoghlan ncoghlan merged commit ae160bb into python:master Feb 25, 2017

1 of 2 checks passed

codecov/patch 9.09% of diff hit (target 100%)
Details
continuous-integration/travis-ci/pr The Travis CI build passed
Details
@ncoghlan

This comment has been minimized.

Copy link
Contributor

commented Feb 25, 2017

For library changes, the What's New guide is generally just a feature-focused summary of the changes added in Misc/NEWS. However, given how conflict-prone Misc/NEWS is at the moment, I went ahead and merged this without the What's New changes (there's generally a review pass through Misc/NEWS around the beta phase to look for feature additions that aren't mentioned in What's New yet).

@ncoghlan ncoghlan added the sprint label May 28, 2017

@ncoghlan

This comment has been minimized.

Copy link
Contributor

commented May 28, 2017

Added the sprint label, as this PR was submitted at the PyCon Pune 2017 core development sprint.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
You can’t perform that action at this time.