Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

bpo-13691: Fixes pydoc help (or help('help')) to show the doc for help #172

Closed
wants to merge 1 commit into from

Conversation

Projects
None yet
5 participants
@CuriousLearner
Copy link
Contributor

commented Feb 19, 2017

This is an attempt to fix issue http://bugs.python.org/issue13691

This is another approach which we could take to resolve the issue around the use of help.

Otherwise we could define a protocol such as introducing __help__ magic method as Nick suggested on the bug.

Please let me know if this needs changes :)

@the-knights-who-say-ni

This comment has been minimized.

Copy link

commented Feb 19, 2017

Hello, and thanks for your contribution!

I'm a bot set up to make sure that the project can legally accept your contribution by verifying you have signed the PSF contributor agreement (CLA).

Unfortunately our records indicate you have not signed the CLA. For legal reasons we need you to sign this before we can look at your contribution. Please follow these steps to rectify the issue:

  1. Sign the PSF contributor agreement
  2. Wait at least one US business day and then check "Your Details" on bugs.python.org to see if your account has been marked as having signed the CLA (the delay is due to a person having to manually check your signed CLA)
  3. Reply here saying you have completed the above steps

Thanks again to your contribution and we look forward to looking at it!

@CuriousLearner

This comment has been minimized.

Copy link
Contributor Author

commented Feb 20, 2017

CLA is signed and now visible in my account.

cc @ncoghlan

@ncoghlan

This comment has been minimized.

Copy link
Contributor

commented Apr 9, 2017

Sorry for taking so long to review this @CuriousLearner.

I'm afraid I really don't like the notion of making pydoc natively aware of _sitebuiltins._Helper - that's two distinct cases of coupling a general purpose module shared across Python implementations to interpreter implementation details that aren't guaranteed to exist outside of CPython.

@ncoghlan ncoghlan closed this Apr 9, 2017

@ncoghlan ncoghlan added the sprint label May 28, 2017

@ncoghlan

This comment has been minimized.

Copy link
Contributor

commented May 28, 2017

Added the sprint label, as this PR was submitted at the PyCon Pune 2017 core development sprint.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
You can’t perform that action at this time.