Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

bpo-38715: Fix compileall.compile_dir() ddir regression #17398

Closed
wants to merge 1 commit into from

Conversation

hetmankp
Copy link
Contributor

@hetmankp hetmankp commented Nov 27, 2019

This fixes a regression introduced in Python 3.5 that means the ddir
parameter on the compileall.compile_dir() function is no longer applied
hierarchically to subdirectories but instead the source path reported in
exception traces is flattened so all subdirectory information is lost.

https://bugs.python.org/issue38715

https://bugs.python.org/issue38715

This fixes a regression introduced in Python 3.5 that means the ddir
parameter on the compileall.compile_dir() function is no longer applied
hierarchically to subdirectories but instead the source path reported in
exception traces is flattened so all subdirectory information is lost.

https://bugs.python.org/issue38715
@the-knights-who-say-ni
Copy link

Hello, and thanks for your contribution!

I'm a bot set up to make sure that the project can legally accept this contribution by verifying everyone involved has signed the PSF contributor agreement (CLA).

Recognized GitHub username

We couldn't find a bugs.python.org (b.p.o) account corresponding to the following GitHub usernames:

@hetmankp

This might be simply due to a missing "GitHub Name" entry in one's b.p.o account settings. This is necessary for legal reasons before we can look at this contribution. Please follow the steps outlined in the CPython devguide to rectify this issue.

You can check yourself to see if the CLA has been received.

Thanks again for the contribution, we look forward to reviewing it!

@hetmankp
Copy link
Contributor Author

Hi, I was unaware of Python's licencing requirements. I would rather completely reassign the copyright for this contribution to the PSF rather than submitting personal details for licencing. If that's not possible, please close this PR.

@csabella
Copy link
Contributor

Thank you, @hetmankp. I'll close the PR as per your request.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants