Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

bpo-39184: Add audit events to command execution functions in os and pty modules #17824

Merged
merged 3 commits into from Feb 5, 2020

Conversation

@gousaiyang
Copy link
Contributor

gousaiyang commented Jan 4, 2020

Add audit events to the following functions:

  • os.exec*
  • os.spawn*
  • os.posix_spawn*
  • os.startfile
  • pty.spawn

https://bugs.python.org/issue39184

https://bugs.python.org/issue39184

@the-knights-who-say-ni

This comment has been minimized.

Copy link

the-knights-who-say-ni commented Jan 4, 2020

Hello, and thanks for your contribution!

I'm a bot set up to make sure that the project can legally accept this contribution by verifying everyone involved has signed the PSF contributor agreement (CLA).

CLA Missing

Our records indicate the following people have not signed the CLA:

@gousaiyang

For legal reasons we need all the people listed to sign the CLA before we can look at your contribution. Please follow the steps outlined in the CPython devguide to rectify this issue.

If you have recently signed the CLA, please wait at least one business day
before our records are updated.

You can check yourself to see if the CLA has been received.

Thanks again for the contribution, we look forward to reviewing it!

@gousaiyang gousaiyang force-pushed the gousaiyang:bpo-39184 branch from 1a4e558 to b65258a Jan 8, 2020
@terryjreedy terryjreedy requested review from zooba and removed request for 1st1, asvetlov, ethanfurman and terryjreedy Jan 8, 2020
@terryjreedy

This comment has been minimized.

Copy link
Member

terryjreedy commented Jan 8, 2020

I was about to close this and tell you to start over with a new PR, but you seem to have corrected it. In the future, do not hit the green [Make Pull Request] button unless the list of commits only has your commits and not those of others. Also, fix the list of suggested reviewers when needed.

@gousaiyang

This comment has been minimized.

Copy link
Contributor Author

gousaiyang commented Jan 8, 2020

Sorry about this, the review request was automatically triggered by the system. I messed up with this branch (should not fetch changes by others) and fixed it by force push.

@zooba

This comment has been minimized.

Copy link
Member

zooba commented Feb 5, 2020

Thanks! These look great!

@zooba zooba merged commit 95f6001 into python:master Feb 5, 2020
9 checks passed
9 checks passed
Docs
Details
Windows (x86)
Details
Windows (x64)
Details
macOS
Details
Ubuntu
Details
Azure Pipelines PR #20200108.25 succeeded
Details
bedevere/issue-number Issue number 39184 found
Details
bedevere/news News entry found in Misc/NEWS.d
continuous-integration/travis-ci/pr The Travis CI build passed
Details
@miss-islington

This comment has been minimized.

Copy link

miss-islington commented Feb 5, 2020

Thanks @gousaiyang for the PR, and @zooba for merging it 🌮🎉.. I'm working now to backport this PR to: 3.8.
🐍🍒🤖

@miss-islington

This comment has been minimized.

Copy link

miss-islington commented Feb 5, 2020

Sorry @gousaiyang and @zooba, I had trouble checking out the 3.8 backport branch.
Please backport using cherry_picker on command line.
cherry_picker 95f6001 3.8

@miss-islington

This comment has been minimized.

Copy link

miss-islington commented Feb 5, 2020

Thanks @gousaiyang for the PR, and @zooba for merging it 🌮🎉.. I'm working now to backport this PR to: 3.8.
🐍🍒🤖 I'm not a witch! I'm not a witch!

miss-islington added a commit to miss-islington/cpython that referenced this pull request Feb 5, 2020
…pty modules (pythonGH-17824)

(cherry picked from commit 95f6001)

Co-authored-by: Saiyang Gou <gousaiyang@163.com>
@bedevere-bot

This comment has been minimized.

Copy link

bedevere-bot commented Feb 5, 2020

GH-18353 is a backport of this pull request to the 3.8 branch.

@gousaiyang gousaiyang deleted the gousaiyang:bpo-39184 branch Feb 5, 2020
miss-islington added a commit that referenced this pull request Feb 5, 2020
…pty modules (GH-17824)

(cherry picked from commit 95f6001)

Co-authored-by: Saiyang Gou <gousaiyang@163.com>
opavlyuk pushed a commit to opavlyuk/cpython that referenced this pull request Feb 12, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Linked issues

Successfully merging this pull request may close these issues.

None yet

6 participants
You can’t perform that action at this time.