Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

bpo-39674: Revert "bpo-37330: open() no longer accept 'U' in file mode (GH-16959)" #18767

Merged
merged 1 commit into from Mar 4, 2020
Merged

bpo-39674: Revert "bpo-37330: open() no longer accept 'U' in file mode (GH-16959)" #18767

merged 1 commit into from Mar 4, 2020

Conversation

vstinner
Copy link
Member

@vstinner vstinner commented Mar 3, 2020

This reverts commit e471e72.

The mode will be removed from Python 3.10.

https://bugs.python.org/issue39674

GH-16959)"

This reverts commit e471e72.

The mode will be removed from Python 3.10.
@vstinner
Copy link
Member Author

vstinner commented Mar 3, 2020

@tirkarthi @serhiy-storchaka: You approved PR #16959. Would you mind to review this revert? See https://bugs.python.org/issue39674 for the rationale.

Copy link
Member

@tirkarthi tirkarthi left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM since it seems to be a straightforward revert of the commit. Thanks Victor.

@vstinner
Copy link
Member Author

vstinner commented Mar 4, 2020

Thanks for the review @tirkarthi ;-)

@vstinner vstinner deleted the revert_u_mode branch March 4, 2020 17:50
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants