Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

bpo-40057: Document some class attributes not mentioned in socketserver doc #19147

Open
wants to merge 1 commit into
base: master
from

Conversation

@OverMighty
Copy link

OverMighty commented Mar 24, 2020

Document the following class attributes, which were previously not mentioned in the documentation of the socketserver module despite of their existence:

StreamRequestHandler.connection (currently defined at line 764 of socketserver.py)
DatagramRequestHandler.packet (currently defined at line 812 of socketserver.py)
DatagramRequestHandler.socket (currently defined at line 812 of socketserver.py)

EDIT:

Perhaps this is poorly worded, as those are actually instance attributes. However, StreamRequestHandler also defines 4 actual class (static) attributes that do not appear anywhere in the docs either, although they are preceded by a comment that describes them in socketserver.py:
rbufsize, wbufsize, timeout and disable_nagle_algorithm.

ForkingMixIn also defines 3 class (static) attributes that do not appear in the docs either and are not preceded by a comment describing them in socketserver.py:
timeout, active_children and max_children

https://bugs.python.org/issue40057

@the-knights-who-say-ni

This comment has been minimized.

Copy link

the-knights-who-say-ni commented Mar 24, 2020

Hello, and thanks for your contribution!

I'm a bot set up to make sure that the project can legally accept this contribution by verifying everyone involved has signed the PSF contributor agreement (CLA).

CLA Missing

Our records indicate the following people have not signed the CLA:

@OverMighty

For legal reasons we need all the people listed to sign the CLA before we can look at your contribution. Please follow the steps outlined in the CPython devguide to rectify this issue.

If you have recently signed the CLA, please wait at least one business day
before our records are updated.

You can check yourself to see if the CLA has been received.

Thanks again for the contribution, we look forward to reviewing it!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Linked issues

Successfully merging this pull request may close these issues.

None yet

3 participants
You can’t perform that action at this time.