Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

bpo-40045: Make "dunder" method documentation easier to locate #19153

Merged
merged 2 commits into from Mar 27, 2020

Conversation

@javadmokhtari
Copy link
Contributor

javadmokhtari commented Mar 25, 2020

@javadmokhtari javadmokhtari changed the title bpo-40045 bpo-40045: Make "dunder" method documentation easier to locate Mar 25, 2020
@aeros aeros added the skip news label Mar 25, 2020
@aeros
aeros approved these changes Mar 25, 2020
Copy link
Member

aeros left a comment

Thanks for the PR @javadmokhtari; LGTM.

Copy link
Contributor

nanjekyejoannah left a comment

Since there was consensus from bpo here : https://bugs.python.org/issue40045, this LGTM. Thanks for your contribution @javadmokhtari .

Some minor consistent line length changes
@aeros

This comment has been minimized.

Copy link
Member

aeros commented Mar 26, 2020

IMO, this should be backported to 3.8 and 3.7.

Copy link
Contributor

nanjekyejoannah left a comment

Let us give @rhettinger time to look. If he doesn't, I will merge this tomorrow.

@nanjekyejoannah nanjekyejoannah merged commit 5f9c131 into python:master Mar 27, 2020
5 checks passed
5 checks passed
Docs
Details
Azure Pipelines PR #20200326.15 succeeded
Details
bedevere/issue-number Issue number 40045 found
Details
bedevere/news "skip news" label found
continuous-integration/travis-ci/pr The Travis CI build passed
Details
@miss-islington

This comment has been minimized.

Copy link
Contributor

miss-islington commented Mar 27, 2020

Thanks @javadmokhtari for the PR, and @nanjekyejoannah for merging it 🌮🎉.. I'm working now to backport this PR to: 3.7, 3.8.
🐍🍒🤖

@bedevere-bot

This comment has been minimized.

Copy link

bedevere-bot commented Mar 27, 2020

@nanjekyejoannah: Please replace # with GH- in the commit message next time. Thanks!

miss-islington added a commit to miss-islington/cpython that referenced this pull request Mar 27, 2020
…nGH-19153)

* issue 40045

* Update lexical_analysis.rst

Make "dunder" method documentation easier(pythonGH-19153)

Co-authored-by: Joannah Nanjekye <33177550+nanjekyejoannah@users.noreply.github.com>
(cherry picked from commit 5f9c131)

Co-authored-by: Javad Mokhtari <javadmokhtari@outlook.com>
@bedevere-bot

This comment has been minimized.

Copy link

bedevere-bot commented Mar 27, 2020

GH-19198 is a backport of this pull request to the 3.8 branch.

miss-islington added a commit to miss-islington/cpython that referenced this pull request Mar 27, 2020
…nGH-19153)

* issue 40045

* Update lexical_analysis.rst

Make "dunder" method documentation easier(pythonGH-19153)

Co-authored-by: Joannah Nanjekye <33177550+nanjekyejoannah@users.noreply.github.com>
(cherry picked from commit 5f9c131)

Co-authored-by: Javad Mokhtari <javadmokhtari@outlook.com>
@bedevere-bot

This comment has been minimized.

Copy link

bedevere-bot commented Mar 27, 2020

GH-19199 is a backport of this pull request to the 3.7 branch.

@aeros

This comment has been minimized.

Copy link
Member

aeros commented Mar 27, 2020

Congrats on your first merged CPython PR, @javadmokhtari! :-)

nanjekyejoannah pushed a commit that referenced this pull request Mar 27, 2020
) (GH-19198)

* issue 40045

* Update lexical_analysis.rst

Make "dunder" method documentation easier(GH-19153)

Co-authored-by: Joannah Nanjekye <33177550+nanjekyejoannah@users.noreply.github.com>
(cherry picked from commit 5f9c131)

Co-authored-by: Javad Mokhtari <javadmokhtari@outlook.com>

Co-authored-by: Javad Mokhtari <javadmokhtari@outlook.com>
nanjekyejoannah pushed a commit that referenced this pull request Mar 27, 2020
) (GH-19199)

* issue 40045

* Update lexical_analysis.rst

Make "dunder" method documentation easier(GH-19153)

Co-authored-by: Joannah Nanjekye <33177550+nanjekyejoannah@users.noreply.github.com>
(cherry picked from commit 5f9c131)

Co-authored-by: Javad Mokhtari <javadmokhtari@outlook.com>

Co-authored-by: Javad Mokhtari <javadmokhtari@outlook.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Linked issues

Successfully merging this pull request may close these issues.

None yet

6 participants
You can’t perform that action at this time.