Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

bpo-40133: Add unittest.mock.matchers with additional matching classes #19310

Closed
wants to merge 2 commits into from

Conversation

Flameeyes
Copy link

@Flameeyes Flameeyes commented Apr 2, 2020

@the-knights-who-say-ni
Copy link

Hello, and thanks for your contribution!

I'm a bot set up to make sure that the project can legally accept this contribution by verifying everyone involved has signed the PSF contributor agreement (CLA).

Recognized GitHub username

We couldn't find a bugs.python.org (b.p.o) account corresponding to the following GitHub usernames:

@Flameeyes

This might be simply due to a missing "GitHub Name" entry in one's b.p.o account settings. This is necessary for legal reasons before we can look at this contribution. Please follow the steps outlined in the CPython devguide to rectify this issue.

You can check yourself to see if the CLA has been received.

Thanks again for the contribution, we look forward to reviewing it!

@Flameeyes
Copy link
Author

FTR the code is coming from Google, who already has a signed CLA for it.

I will be able to sign my individual CLA this coming Saturday, for any follow up.

@csabella
Copy link
Contributor

csabella commented May 23, 2020

@Flameeyes, thank you for the suggestion and for the contribution. As per the comments on the bug tracker issue, I'm going to close this as it would be better suited to a PyPI package. It can be reopened if additional discussion makes this a suitable addition to the standard library. Thanks!

@csabella csabella closed this May 23, 2020
@gpshead
Copy link
Member

gpshead commented May 23, 2020

see the bug.

@gpshead gpshead reopened this May 23, 2020
@gpshead gpshead self-assigned this May 23, 2020
@csabella
Copy link
Contributor

Thanks, @gpshead! :-)

@cjw296
Copy link
Contributor

cjw296 commented Jun 18, 2020

@gpshead - please don't merge this without further discussion on the bug.

@gpshead
Copy link
Member

gpshead commented Jun 18, 2020

mock's owners don't want these features as is. We can create a new PR for the subset of things that make sense if any.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

6 participants