Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

bpo-42065: Fix incorrectly formatted _codecs.charmap_decode error message #19940

Merged
merged 2 commits into from Oct 17, 2020

Conversation

tekknolagi
Copy link
Contributor

@tekknolagi tekknolagi commented May 5, 2020

The formatter does not support %lx. Add previously failing tests.

https://bugs.python.org/issue42065

The formatter does not support `%lx`. Add previously failing tests.
@tekknolagi
Copy link
Contributor Author

tekknolagi commented May 5, 2020

I imagine this is minor enough that news & issue are not required. If this is not the case, happy to make one or both.

@csabella
Copy link
Contributor

csabella commented May 29, 2020

@tekknolagi, thank you for the pull request. You'd probably get more visibility on this with an issue on the bug tracker. It's easy for pull requests to be missed without a corresponding issue.

@tekknolagi
Copy link
Contributor Author

tekknolagi commented May 29, 2020

Is it mergeable as-is or should I make an issue?

@csabella
Copy link
Contributor

csabella commented May 31, 2020

Please make an issue.

@taleinat
Copy link
Contributor

taleinat commented Oct 17, 2020

Indeed, as a bugfix, this needs an issue and a NEWS entry.

@tekknolagi, is this something you're willing to do?

@taleinat
Copy link
Contributor

taleinat commented Oct 17, 2020

Never mind, I'll do it myself. This is a good fix for an obvious bug, and the tests are good, so I'd like to get this in.

@taleinat taleinat changed the title Fix incorrectly formatted _codecs.charmap_decode error message bpo-42065: Fix incorrectly formatted _codecs.charmap_decode error message Oct 17, 2020
Copy link
Contributor

@taleinat taleinat left a comment

LGTM

@taleinat taleinat added needs backport to 3.8 needs backport to 3.9 type-bug An unexpected behavior, bug, or error labels Oct 17, 2020
@taleinat taleinat merged commit 3635388 into python:master Oct 17, 2020
3 checks passed
@miss-islington
Copy link
Contributor

miss-islington commented Oct 17, 2020

Thanks @tekknolagi for the PR, and @taleinat for merging it 🌮🎉.. I'm working now to backport this PR to: 3.8, 3.9.
🐍🍒🤖 I'm not a witch! I'm not a witch!

@bedevere-bot
Copy link

bedevere-bot commented Oct 17, 2020

GH-22743 is a backport of this pull request to the 3.9 branch.

miss-islington pushed a commit to miss-islington/cpython that referenced this pull request Oct 17, 2020
…sage (pythonGH-19940)

(cherry picked from commit 3635388)

Co-authored-by: Max Bernstein <tekknolagi@users.noreply.github.com>
miss-islington pushed a commit to miss-islington/cpython that referenced this pull request Oct 17, 2020
…sage (pythonGH-19940)

(cherry picked from commit 3635388)

Co-authored-by: Max Bernstein <tekknolagi@users.noreply.github.com>
@bedevere-bot
Copy link

bedevere-bot commented Oct 17, 2020

GH-22744 is a backport of this pull request to the 3.8 branch.

@taleinat
Copy link
Contributor

taleinat commented Oct 17, 2020

Thanks for this PR, @tekknolagi!

@tekknolagi
Copy link
Contributor Author

tekknolagi commented Oct 17, 2020

Thanks for adding the news entry, etc. I could not find the time nor the energy

xzy3 pushed a commit to xzy3/cpython that referenced this pull request Oct 18, 2020
@taleinat
Copy link
Contributor

taleinat commented Oct 18, 2020

That's fine, @tekknolagi.

For future reference, blurb-it makes adding NEWS entries to PRs very easy.

taleinat pushed a commit that referenced this pull request Oct 18, 2020
…sage (GH-19940)

(cherry picked from commit 3635388)

Co-authored-by: Max Bernstein <tekknolagi@users.noreply.github.com>
taleinat pushed a commit that referenced this pull request Oct 18, 2020
…sage (GH-19940)

(cherry picked from commit 3635388)

Co-authored-by: Max Bernstein <tekknolagi@users.noreply.github.com>
adorilson pushed a commit to adorilson/cpython that referenced this pull request Mar 13, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
type-bug An unexpected behavior, bug, or error
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

6 participants