bpo-40801: Add operator.as_float #20481
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
mdickinson
commented
May 28, 2020
mdickinson
commented
May 28, 2020
mdickinson
commented
May 28, 2020
csabella
reviewed
May 28, 2020
| pass | ||
|
|
||
| if bad_type: | ||
| raise TypeError(f"must be real number, not {obj.__class__.__name__}") |
There was a problem hiding this comment.
Do you mean real number in the math sense? Or do you mean it as instead of a string representation of a number?
There was a problem hiding this comment.
In the mathematical sense. But this wording isn't new to this PR; it's copied from here.
There was a problem hiding this comment.
Thanks. That makes sense. :-)
|
Converted this PR to draft; the feature is still under discussion. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR exposes
PyFloat_AsDoubleto Python level in the formoperator.as_float. This provides a way for Python code to emulate the implicit float conversions that Python itself does at C level.https://bugs.python.org/issue40801