bpo-41870: Avoid the test when nargs=0 #22462
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
pablogsal
approved these changes
Sep 30, 2020
pablogsal
reviewed
Sep 30, 2020
| return NULL; | ||
| if (ok < 0) { | ||
| return NULL; | ||
| } | ||
| } | ||
| return PyBool_FromLong(ok); |
There was a problem hiding this comment.
I assume it won't make a difference because PyBool_FromLong will be likely smashed (inlined 😉 ) by the compiler, but can you check if there is any improvement in making the branch yourself here?
Basically changing the PyBool_FromLong(ok) to a conditional with Py_RETURN_TRUE and Py_RETURN_FALSE
There was a problem hiding this comment.
@pablogsal
I checked it locally and there was no improvement. :)
I will merge this PR without changing ;)
Thank you for the review!
There was a problem hiding this comment.
@pablogsal If you want to ensure that a function is inlined, I suggest to add a new variant of PyBool_FromLong() which is delcared as a static inline function.
|
@corona10: Perfect, thanks! |
xzy3
pushed a commit
to xzy3/cpython
that referenced
this pull request
Oct 18, 2020
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
https://bugs.python.org/issue41870