New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

bpo-30693: zip+tarfile: sort directory listing #2263

Merged
merged 2 commits into from Jan 31, 2018

Conversation

Projects
None yet
5 participants
@bmwiedemann
Contributor

bmwiedemann commented Jun 18, 2017

zipfile+tarfile: sort directory listing
to generate zip and tar archives in a more reproducible way

See also https://reproducible-builds.org/docs/stable-inputs/ on that topic.

I successfully tested this change on python-2.7.13

https://bugs.python.org/issue30693

bmwiedemann added a commit to bmwiedemann/obs-service-tar_scm that referenced this pull request Jun 18, 2017

@bmwiedemann bmwiedemann referenced this pull request Jun 18, 2017

Merged

Sort tar file list #168

bmwiedemann added a commit to bmwiedemann/obs-service-tar_scm that referenced this pull request Jun 19, 2017

Sort tar file list
to generate tar files in a reproducible way.

See https://reproducible-builds.org/ for why this matters.

In addition to this change,
to generate completely reproducible tarballs,
the build system also needs
python/cpython#2263

@bmwiedemann bmwiedemann changed the title from bpo-30693: tarfile: sort directory listing to bpo-30693: zip+tarfile: sort directory listing Jun 21, 2017

@bitdancer

This needs a news item and a doc update.

bmwiedemann added some commits Jun 18, 2017

bpo-30693: tarfile: sort directory listing
to generate tar files in a more reproducible way

See also https://reproducible-builds.org/docs/stable-inputs/ on that topic.
bpo-30693: zipfile: sort directory listing
to generate zip files in a more reproducible way

See also https://reproducible-builds.org/docs/stable-inputs/ on that topic.
@bmwiedemann

This comment has been minimized.

Show comment
Hide comment
@bmwiedemann

bmwiedemann Jan 24, 2018

Contributor

updated docs to include a versionchanged as requested by one dev.
News entry was already there anyway.

Contributor

bmwiedemann commented Jan 24, 2018

updated docs to include a versionchanged as requested by one dev.
News entry was already there anyway.

@bmwiedemann

This comment has been minimized.

Show comment
Hide comment
@bmwiedemann

bmwiedemann Jan 25, 2018

Contributor

@brettcannon since you seem to be interested in this topic, I would really like to see the 1-line fix to tarfile.py merged

Contributor

bmwiedemann commented Jan 25, 2018

@brettcannon since you seem to be interested in this topic, I would really like to see the 1-line fix to tarfile.py merged

@vstinner vstinner merged commit 8452104 into python:master Jan 31, 2018

4 checks passed

bedevere/issue-number Issue number 30693 found
Details
bedevere/news News entry found in Misc/NEWS.d
continuous-integration/appveyor/pr AppVeyor build succeeded
Details
continuous-integration/travis-ci/pr The Travis CI build passed
Details
@bedevere-bot

This comment has been minimized.

Show comment
Hide comment
@bedevere-bot

bedevere-bot Jan 31, 2018

@vstinner: Please replace # with GH- in the commit message next time. Thanks!

bedevere-bot commented Jan 31, 2018

@vstinner: Please replace # with GH- in the commit message next time. Thanks!

ned-deily added a commit to ned-deily/cpython that referenced this pull request Jan 31, 2018

bpo-30693: zip+tarfile: sort directory listing (#2263)
tarfile and zipfile now sort directory listing to generate tar and zip archives
in a more reproducible way.

See also https://reproducible-builds.org/docs/stable-inputs/ on that topic.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment