Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

bpo-30693: zip+tarfile: sort directory listing #2263

Merged
merged 2 commits into from Jan 31, 2018

Conversation

Projects
None yet
5 participants
@bmwiedemann
Copy link
Contributor

commented Jun 18, 2017

zipfile+tarfile: sort directory listing
to generate zip and tar archives in a more reproducible way

See also https://reproducible-builds.org/docs/stable-inputs/ on that topic.

I successfully tested this change on python-2.7.13

https://bugs.python.org/issue30693

bmwiedemann added a commit to bmwiedemann/obs-service-tar_scm that referenced this pull request Jun 18, 2017

@bmwiedemann bmwiedemann referenced this pull request Jun 18, 2017

Merged

Sort tar file list #168

bmwiedemann added a commit to bmwiedemann/obs-service-tar_scm that referenced this pull request Jun 19, 2017

Sort tar file list
to generate tar files in a reproducible way.

See https://reproducible-builds.org/ for why this matters.

In addition to this change,
to generate completely reproducible tarballs,
the build system also needs
python/cpython#2263

@bmwiedemann bmwiedemann changed the title bpo-30693: tarfile: sort directory listing bpo-30693: zip+tarfile: sort directory listing Jun 21, 2017

@bmwiedemann bmwiedemann force-pushed the distropatches:tarfile branch from 5b10c5b to e8010eb Jun 21, 2017

@bmwiedemann bmwiedemann force-pushed the distropatches:tarfile branch 4 times, most recently from 51d3ad6 to b5551df Nov 27, 2017

@bmwiedemann bmwiedemann force-pushed the distropatches:tarfile branch from b5551df to 0c70a5f Jan 17, 2018

@bitdancer
Copy link
Member

left a comment

This needs a news item and a doc update.

@bmwiedemann bmwiedemann force-pushed the distropatches:tarfile branch from 0c70a5f to 1840f8b Jan 17, 2018

bmwiedemann added some commits Jun 18, 2017

bpo-30693: tarfile: sort directory listing
to generate tar files in a more reproducible way

See also https://reproducible-builds.org/docs/stable-inputs/ on that topic.
bpo-30693: zipfile: sort directory listing
to generate zip files in a more reproducible way

See also https://reproducible-builds.org/docs/stable-inputs/ on that topic.

@bmwiedemann bmwiedemann force-pushed the distropatches:tarfile branch from 1840f8b to 19c0d68 Jan 24, 2018

@bmwiedemann

This comment has been minimized.

Copy link
Contributor Author

commented Jan 24, 2018

updated docs to include a versionchanged as requested by one dev.
News entry was already there anyway.

@bmwiedemann

This comment has been minimized.

Copy link
Contributor Author

commented Jan 25, 2018

@brettcannon since you seem to be interested in this topic, I would really like to see the 1-line fix to tarfile.py merged

@vstinner vstinner merged commit 8452104 into python:master Jan 31, 2018

4 checks passed

bedevere/issue-number Issue number 30693 found
Details
bedevere/news News entry found in Misc/NEWS.d
continuous-integration/appveyor/pr AppVeyor build succeeded
Details
continuous-integration/travis-ci/pr The Travis CI build passed
Details
@bedevere-bot

This comment has been minimized.

Copy link

commented Jan 31, 2018

@vstinner: Please replace # with GH- in the commit message next time. Thanks!

ned-deily added a commit to ned-deily/cpython that referenced this pull request Jan 31, 2018

bpo-30693: zip+tarfile: sort directory listing (python#2263)
tarfile and zipfile now sort directory listing to generate tar and zip archives
in a more reproducible way.

See also https://reproducible-builds.org/docs/stable-inputs/ on that topic.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
You can’t perform that action at this time.