From adc5a9939ba656c938baab9941f7893c46edb394 Mon Sep 17 00:00:00 2001 From: Justin Turner Arthur Date: Mon, 19 Oct 2020 20:18:57 -0500 Subject: [PATCH] bpo-38912: fix close before connect callback in test_asyncio SSL tests (GH-22691) Reduces the rate at which the ENV CHANGED failure occurs in test_asyncio SSL tests (due to unclosed transport), but does not 100% resolve it. (cherry picked from commit de73d432bb29f6439f2db16cb991e15e09c70c26) Co-authored-by: Justin Turner Arthur --- Lib/test/test_asyncio/test_events.py | 2 ++ Misc/ACKS | 1 + 2 files changed, 3 insertions(+) diff --git a/Lib/test/test_asyncio/test_events.py b/Lib/test/test_asyncio/test_events.py index 7bc9c9a344c9d38..92b1522e956c405 100644 --- a/Lib/test/test_asyncio/test_events.py +++ b/Lib/test/test_asyncio/test_events.py @@ -1075,6 +1075,7 @@ def test_create_unix_server_ssl_verified(self): ssl=sslcontext_client, server_hostname='localhost') client, pr = self.loop.run_until_complete(f_c) + self.loop.run_until_complete(proto.connected) # close connection proto.transport.close() @@ -1100,6 +1101,7 @@ def test_create_server_ssl_verified(self): ssl=sslcontext_client, server_hostname='localhost') client, pr = self.loop.run_until_complete(f_c) + self.loop.run_until_complete(proto.connected) # extra info is available self.check_ssl_extra_info(client, peername=(host, port), diff --git a/Misc/ACKS b/Misc/ACKS index 3125600284daf44..2aa9a9de93703e9 100644 --- a/Misc/ACKS +++ b/Misc/ACKS @@ -70,6 +70,7 @@ Alexandru Ardelean Emmanuel Arias Alicia Arlen Jeffrey Armstrong +Justin Turner Arthur Jason Asbahr David Ascher Ammar Askar